[InstSimplify] Fix SimplifyGEPInst when GEP index type is vector type.

[huihuiz]

Summary

The following folds

"gep (gep V, C), (sub 0, V) -> C"
"gep (gep V, C), (xor V, -1) -> C-1"

are only valid when GEP index type is scalar type.

This patch bailout early when GEP index type is vector type. Explicitly call
TypeSize::getFixedSize to assert on places where scalable type doesn't make sense.

[huihuiz]

Take test.ll, run opt -S -instsimplify -o -
Then you will get the compiler warning: Compiler has made implicit assumption that TypeSize is not scalable.

define <vscale x 16 x i8*> @getelementptr_src_ty_not_vscale(<vscale x 16 x i8*> %a, <vscale x 16 x i64> %offset) {
  %v = getelementptr i8, <vscale x 16 x i8*> %a, <vscale x 16 x i64> %offset
  ret <vscale x 16 x i8*> %v
}

For this case SrcTy is i8

[efriedma]

There are two different kinds of "scalable" involved when you're dealing with GEPs: whether you're indexing over a scalable type, and whether the result is a scalable vector of pointers. Mixing the two together into a single boolean doesn't really make sense.

In this context, I'm not sure why it would matter whether the result is a vector of pointers.

[huihuiz]

My initial thought was wrong.
Spent sometime look again, we are nearly impossible to generate incorrect result without the code fixes in this patch.
But comparing a scalable size with a fixed size still doesn't make sense.

E.g., We are comparing scalable type size %offset to a fixed size 'IdxWidth' returned by DataLayout::getIndexSizeInBits

define <vscale x 1 x i8*> @gep(i8* %a, <vscale x 1 x i32> %offset) {
  %v = getelementptr i8, i8* %a, <vscale x 1 x i32> %offset
  ret <vscale x 1 x i8*> %v
}

Please help take a look, let me know what you think?

[efriedma]

llvm/lib/Analysis/InstructionSimplify.cpp

4150

This is supposed to be comparing the size of the scalar types, I think? Scalar types can't be scalable.

That said, it looks like the code isn't actually doing that at the moment.

[huihuiz]

Thanks Eli for the feedback!

Update the patch to address the folds in question, reject if GEP index type is vector type.

[efriedma]

llvm/lib/Analysis/InstructionSimplify.cpp

4143

I think the transform is still valid, it just isn't implemented.

llvm/lib/Analysis/InstructionSimplify.cpp

   if (VectorType *VT = dyn_cast<VectorType>(Ops[0]->getType()))
     GEPTy = VectorType::get(GEPTy, VT->getElementCount());
   else if (VectorType *VT = dyn_cast<VectorType>(Ops[1]->getType()))
     GEPTy = VectorType::get(GEPTy, VT->getElementCount());
 
   if (isa<UndefValue>(Ops[0]))
     return UndefValue::get(GEPTy);
 
-  bool IsScalableVec =
-      SrcTy->isVectorTy() ? SrcTy->getVectorIsScalable() : false;
+  bool IsScalableVec = false;
+  if (SrcTy->isVectorTy() && SrcTy->getVectorIsScalable())
+    IsScalableVec = true;
+  else
+    for (auto Op : Ops)
+      if (Op->getType()->isVectorTy() && Op->getType()->getVectorIsScalable()) {
+        IsScalableVec = true;
+        break;
+      }
 
   if (Ops.size() == 2) {
     // getelementptr P, 0 -> P.
     if (match(Ops[1], m_Zero()) && Ops[0]->getType() == GEPTy)
       return Ops[0];
 
     Type *Ty = SrcTy;
     if (!IsScalableVec && Ty->isSized()) {

 
         // getelementptr V, (sdiv (sub P, V), C) -> Q
         // if P points to a type of size C.
         if (match(Ops[1],
                   m_SDiv(m_Sub(m_Value(P), m_PtrToInt(m_Specific(Ops[0]))),
                          m_SpecificInt(TyAllocSize))))
           if (Value *R = PtrToIntOrZero(P))
             return R;
       }
     }
   }
 
   if (!IsScalableVec && Q.DL.getTypeAllocSize(LastType) == 1 &&
       all_of(Ops.slice(1).drop_back(1),
              [](Value *Idx) { return match(Idx, m_Zero()); })) {
     unsigned IdxWidth =
         Q.DL.getIndexSizeInBits(Ops[0]->getType()->getPointerAddressSpace());
     if (Q.DL.getTypeSizeInBits(Ops.back()->getType()) == IdxWidth) {
       APInt BasePtrOffset(IdxWidth, 0);
       Value *StrippedBasePtr =
           Ops[0]->stripAndAccumulateInBoundsConstantOffsets(Q.DL,
                                                             BasePtrOffset);
 
       // gep (gep V, C), (sub 0, V) -> C

llvm/test/Transforms/InstSimplify/vscale.ll

 define i1 @getelementptr_check_non_null(<vscale x 16 x i8>* %ptr) {
 ; CHECK-LABEL: @getelementptr_check_non_null(
 ; CHECK-NEXT:    ret i1 false
 ;
   %x = getelementptr inbounds <vscale x 16 x i8>, <vscale x 16 x i8>* %ptr, i32 1
   %cmp = icmp eq <vscale x 16 x i8>* %x, null
   ret i1 %cmp
 }
+
+define <vscale x 16 x i8*> @getelementptr_src_ty_not_vscale(<vscale x 16 x i8*> %a, <vscale x 16 x i64> %offset) {
+; CHECK-LABEL: @getelementptr_src_ty_not_vscale(
+; CHECK-NEXT:    [[V:%.*]] = getelementptr i8, <vscale x 16 x i8*> [[A:%.*]], <vscale x 16 x i64> [[OFFSET:%.*]]
+; CHECK-NEXT:    ret <vscale x 16 x i8*> [[V]]
+;
+  %v = getelementptr i8, <vscale x 16 x i8*> %a, <vscale x 16 x i64> %offset
+  ret <vscale x 16 x i8*> %v
+}