This is an archive of the discontinued LLVM Phabricator instance.

Differential D76310

[Hexagon] Add linux #defines when linux triple is selected
ClosedPublic

Authored by sidneym on Mar 17 2020, 11:55 AM.

Details

Reviewers
bcain
kparzysz
adasgupt
Commits
rG430c9a80c17b: [Hexagon] Enable linux #defines
Summary

Add Linux default defines when the triple includes -linux-musl.

Diff Detail

Event Timeline

sidneym created this revision.Mar 17 2020, 11:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 17 2020, 11:55 AM
Herald added subscribers: cfe-commits, krytarowski. · View Herald Transcript
Harbormaster completed remote builds in B49464: Diff 250846.Mar 17 2020, 12:57 PM
bcain added a comment.Mar 18 2020, 9:56 AM

LGTM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 19 2020, 12:35 PM
Closed by commit rG430c9a80c17b: [Hexagon] Enable linux #defines (authored by sidneym). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang/
lib/
Basic/
3 lines
test/
Preprocessor/
12 lines

Diff 251449

clang/lib/Basic/Targets.cpp

Show First 20 Lines • Show All 111 Lines • ▼ Show 20 LinesTargetInfo *AllocateTarget(const llvm::Triple &Triple,
case llvm::Triple::arc: case llvm::Triple::arc:
return new ARCTargetInfo(Triple, Opts); return new ARCTargetInfo(Triple, Opts);
case llvm::Triple::xcore: case llvm::Triple::xcore:
return new XCoreTargetInfo(Triple, Opts); return new XCoreTargetInfo(Triple, Opts);
case llvm::Triple::hexagon: case llvm::Triple::hexagon:
if (os == llvm::Triple::Linux &&
Triple.getEnvironment() == llvm::Triple::Musl)
return new LinuxTargetInfo<HexagonTargetInfo>(Triple, Opts);
return new HexagonTargetInfo(Triple, Opts); return new HexagonTargetInfo(Triple, Opts);
case llvm::Triple::lanai: case llvm::Triple::lanai:
return new LanaiTargetInfo(Triple, Opts); return new LanaiTargetInfo(Triple, Opts);
case llvm::Triple::aarch64_32: case llvm::Triple::aarch64_32:
if (Triple.isOSDarwin()) if (Triple.isOSDarwin())
return new DarwinAArch64TargetInfo(Triple, Opts); return new DarwinAArch64TargetInfo(Triple, Opts);
▲ Show 20 Lines • Show All 555 Lines • Show Last 20 Lines

clang/test/Preprocessor/hexagon-predefines.c

Show First 20 Lines • Show All 95 Lines • ▼ Show 20 Lines
// CHECK-V67HVX-128B: #define __HVX_LENGTH__ 128 // CHECK-V67HVX-128B: #define __HVX_LENGTH__ 128
// CHECK-V67HVX-128B: #define __HVX__ 1 // CHECK-V67HVX-128B: #define __HVX__ 1
// CHECK-V67HVX-128B: #define __hexagon__ 1 // CHECK-V67HVX-128B: #define __hexagon__ 1
// RUN: %clang_cc1 -E -dM -triple hexagon-unknown-elf -target-cpu hexagonv67 \ // RUN: %clang_cc1 -E -dM -triple hexagon-unknown-elf -target-cpu hexagonv67 \
// RUN: -target-feature +hvxv67 -target-feature +hvx-length128b %s | FileCheck \ // RUN: -target-feature +hvxv67 -target-feature +hvx-length128b %s | FileCheck \
// RUN: %s -check-prefix CHECK-ELF // RUN: %s -check-prefix CHECK-ELF
// CHECK-ELF: #define __ELF__ 1 // CHECK-ELF: #define __ELF__ 1
// RUN: %clang_cc1 -E -dM -triple hexagon-unknown-linux-musl \
// RUN: -target-cpu hexagonv67 -target-feature +hvxv67 \
// RUN: -target-feature +hvx-length128b %s | FileCheck \
// RUN: %s -check-prefix CHECK-LINUX
// CHECK-LINUX: #define __gnu_linux__ 1
// CHECK-LINUX: #define __linux 1
// CHECK-LINUX: #define __linux__ 1
// CHECK-LINUX: #define __unix 1
// CHECK-LINUX: #define __unix__ 1
// CHECK-LINUX: #define linux 1
// CHECK-LINUX: #define unix 1