This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Fix whole wavefront mode
ClosedPublic

Authored by Flakebi on Mar 16 2020, 8:48 AM.

Details

Summary

We cannot move wwm over exec copies because the exec register needs an exact exec mask.

Diff Detail

Event Timeline

Flakebi created this revision.Mar 16 2020, 8:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2020, 8:48 AM
arsenm added inline comments.Mar 16 2020, 9:22 AM
llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp
526–527

Can't this whole function be replaced with SIInstrInfo::mayReadExec?

llvm/test/CodeGen/AMDGPU/wqm.mir
119–147

Should be able to remove all of this (except tracksRegLiveness: true)

Flakebi updated this revision to Diff 250707.Mar 17 2020, 2:40 AM

Use mayReadEXEC as suggested by Matt.

This revision is now accepted and ready to land.Mar 17 2020, 3:37 AM
This revision was automatically updated to reflect the committed changes.