This is an archive of the discontinued LLVM Phabricator instance.

Differential D75605

[lld] Avoid creating files outside of work directory.
ClosedPublic

Authored by herhut on Mar 4 2020, 5:42 AM.

Details

Reviewers
• espindola
bkramer
Commits
rG573c9d666c0f: [lld] Avoid creating files outside of work directory.
Summary

A test is passing -o - to lld in the hope of writing the output to
standard out but that is not the case. Instead it creates a file named
-.lto.o. This fixes it by creating a temporary file in the work
directory.

Diff Detail

Event Timeline

herhut created this revision.Mar 4 2020, 5:42 AM
Herald added a reviewer: • espindola. · View Herald TranscriptMar 4 2020, 5:42 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, dexonsmith, steven_wu and 3 others. · View Herald Transcript
bkramer accepted this revision.Mar 4 2020, 5:43 AM
bkramer added a subscriber: bkramer.

looks good

This revision is now accepted and ready to land.Mar 4 2020, 5:43 AM
Closed by commit rG573c9d666c0f: [lld] Avoid creating files outside of work directory. (authored by herhut). · Explain WhyMar 4 2020, 6:11 AM
This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B48038: Diff 248157.Mar 4 2020, 7:52 AM

Revision Contents

PathSize
lld/
test/
ELF/
lto/
2 lines

Diff 248165

lld/test/ELF/lto/thinlto.ll

Show All 20 Lines
; RUN: llvm-nm %t31.lto.o | FileCheck %s --check-prefix=NM1 ; RUN: llvm-nm %t31.lto.o | FileCheck %s --check-prefix=NM1
; RUN: llvm-nm %t32.lto.o | FileCheck %s --check-prefix=NM2 ; RUN: llvm-nm %t32.lto.o | FileCheck %s --check-prefix=NM2
; Check that -save-temps is usable with thin archives ; Check that -save-temps is usable with thin archives
; RUN: rm -fr %t.dir ; RUN: rm -fr %t.dir
; RUN: mkdir -p %t.dir ; RUN: mkdir -p %t.dir
; RUN: cp %t2.o %t.dir/t.o ; RUN: cp %t2.o %t.dir/t.o
; RUN: llvm-ar rcsT %t.dir/t.a %t.dir/t.o ; RUN: llvm-ar rcsT %t.dir/t.a %t.dir/t.o
; RUN: ld.lld -save-temps %t1.o %t.dir/t.a -o - > /dev/null ; RUN: ld.lld -save-temps %t1.o %t.dir/t.a -o %t.null
; RUN: ls '%t.dir/t.a(t.o at 0).0.preopt.bc' ; RUN: ls '%t.dir/t.a(t.o at 0).0.preopt.bc'
; NM1: T f ; NM1: T f
; NM2: T g ; NM2: T g
target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128" target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu" target triple = "x86_64-unknown-linux-gnu"
declare void @g(...) declare void @g(...)
define void @f() { define void @f() {
entry: entry:
call void (...) @g() call void (...) @g()
ret void ret void
} }