This is an archive of the discontinued LLVM Phabricator instance.

Differential D73864

[X86] FUCOMI/FCOMI instructions should Def FPSW not FPCW.
ClosedPublic

Authored by craig.topper on Feb 2 2020, 11:32 PM.

Details

Reviewers
pengfei
RKSimon
spatel
LiuChen3
Commits
rG028579b51e57: [X86] FUCOMI/FCOMI instructions should Def FPSW not FPCW.
Summary

These instructions can set the exception in FPSW. But I
don't think they can change FPCW. So this looks like a typo.

Diff Detail

Event Timeline

craig.topper created this revision.Feb 2 2020, 11:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 2 2020, 11:32 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
Harbormaster completed remote builds in B45551: Diff 241974.Feb 2 2020, 11:33 PM
pengfei accepted this revision.Feb 3 2020, 3:29 AM

Agreed, LGTM.

This revision is now accepted and ready to land.Feb 3 2020, 3:29 AM
Closed by commit rG028579b51e57: [X86] FUCOMI/FCOMI instructions should Def FPSW not FPCW. (authored by craig.topper). · Explain WhyFeb 3 2020, 7:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
Target/
X86/
2 lines

Diff 242077

llvm/lib/Target/X86/X86InstrFPStack.td

Show First 20 Lines • Show All 639 Lines • ▼ Show 20 Linesdef COM_Fpr64 : FpIf64<(outs), (ins RFP64:$lhs, RFP64:$rhs), CompareFP,
[(set FPSW, (trunc (X86strict_fcmps RFP64:$lhs, RFP64:$rhs)))]>; [(set FPSW, (trunc (X86strict_fcmps RFP64:$lhs, RFP64:$rhs)))]>;
def COM_Fpr80 : FpI_ <(outs), (ins RFP80:$lhs, RFP80:$rhs), CompareFP, def COM_Fpr80 : FpI_ <(outs), (ins RFP80:$lhs, RFP80:$rhs), CompareFP,
[(set FPSW, (trunc (X86strict_fcmps RFP80:$lhs, RFP80:$rhs)))]>; [(set FPSW, (trunc (X86strict_fcmps RFP80:$lhs, RFP80:$rhs)))]>;
} // SchedRW } // SchedRW
} // mayRaiseFPException = 1 } // mayRaiseFPException = 1
let SchedRW = [WriteFCom], mayRaiseFPException = 1 in { let SchedRW = [WriteFCom], mayRaiseFPException = 1 in {
// CC = ST(0) cmp ST(i) // CC = ST(0) cmp ST(i)
let Defs = [EFLAGS, FPCW], Uses = [FPCW] in { let Defs = [EFLAGS, FPSW], Uses = [FPCW] in {
def UCOM_FpIr32: FpI_<(outs), (ins RFP32:$lhs, RFP32:$rhs), CompareFP, def UCOM_FpIr32: FpI_<(outs), (ins RFP32:$lhs, RFP32:$rhs), CompareFP,
[(set EFLAGS, (X86any_fcmp RFP32:$lhs, RFP32:$rhs))]>, [(set EFLAGS, (X86any_fcmp RFP32:$lhs, RFP32:$rhs))]>,
Requires<[FPStackf32, HasCMov]>; Requires<[FPStackf32, HasCMov]>;
def UCOM_FpIr64: FpI_<(outs), (ins RFP64:$lhs, RFP64:$rhs), CompareFP, def UCOM_FpIr64: FpI_<(outs), (ins RFP64:$lhs, RFP64:$rhs), CompareFP,
[(set EFLAGS, (X86any_fcmp RFP64:$lhs, RFP64:$rhs))]>, [(set EFLAGS, (X86any_fcmp RFP64:$lhs, RFP64:$rhs))]>,
Requires<[FPStackf64, HasCMov]>; Requires<[FPStackf64, HasCMov]>;
def UCOM_FpIr80: FpI_<(outs), (ins RFP80:$lhs, RFP80:$rhs), CompareFP, def UCOM_FpIr80: FpI_<(outs), (ins RFP80:$lhs, RFP80:$rhs), CompareFP,
[(set EFLAGS, (X86any_fcmp RFP80:$lhs, RFP80:$rhs))]>, [(set EFLAGS, (X86any_fcmp RFP80:$lhs, RFP80:$rhs))]>,
▲ Show 20 Lines • Show All 158 Lines • Show Last 20 Lines