This is an archive of the discontinued LLVM Phabricator instance.

Differential D73489

[mips][NFC] Remove unused instruction formats
ClosedPublic

Authored by mstojanovic on Jan 27 2020, 8:20 AM.

Details

Reviewers
atanasyan
petarj
Commits
rG4c8817cddf6a: [mips][NFC] Remove unused instruction formats
Summary

BranchBase unused sice: rL170663
FI unsused since: rL170954
FFI unused since: rL190221

Diff Detail

Event Timeline

mstojanovic created this revision.Jan 27 2020, 8:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 27 2020, 8:20 AM
Herald added subscribers: hiraditya, arichardson, sdardis. · View Herald Transcript
atanasyan accepted this revision.Jan 27 2020, 11:53 AM

LGTM
Thanks

This revision is now accepted and ready to land.Jan 27 2020, 11:53 AM
Closed by commit rG4c8817cddf6a: [mips][NFC] Remove unused instruction formats (authored by mstojanovic). · Explain WhyJan 28 2020, 4:41 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: jrtc27. · View Herald TranscriptJan 28 2020, 4:41 AM

Revision Contents

PathSize
llvm/
lib/
Target/
Mips/
47 lines

Diff 240839

llvm/lib/Target/Mips/MipsInstrFormats.td

Show First 20 Lines • Show All 163 Lines • ▼ Show 20 Linesclass FR<bits<6> op, bits<6> _funct, dag outs, dag ins, string asmstr,
let Inst{25-21} = rs; let Inst{25-21} = rs;
let Inst{20-16} = rt; let Inst{20-16} = rt;
let Inst{15-11} = rd; let Inst{15-11} = rd;
let Inst{10-6} = shamt; let Inst{10-6} = shamt;
let Inst{5-0} = funct; let Inst{5-0} = funct;
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Format I instruction class in Mips : <|opcode|rs|rt|immediate|>
//===----------------------------------------------------------------------===//
class FI<bits<6> op, dag outs, dag ins, string asmstr, list<dag> pattern,
InstrItinClass itin>: InstSE<outs, ins, asmstr, pattern, itin, FrmI>
{
bits<5> rt;
bits<5> rs;
bits<16> imm16;
let Opcode = op;
let Inst{25-21} = rs;
let Inst{20-16} = rt;
let Inst{15-0} = imm16;
}
class BranchBase<bits<6> op, dag outs, dag ins, string asmstr,
list<dag> pattern, InstrItinClass itin>:
InstSE<outs, ins, asmstr, pattern, itin, FrmI>
{
bits<5> rs;
bits<5> rt;
bits<16> imm16;
let Opcode = op;
let Inst{25-21} = rs;
let Inst{20-16} = rt;
let Inst{15-0} = imm16;
}
//===----------------------------------------------------------------------===//
// Format J instruction class in Mips : <|opcode|address|> // Format J instruction class in Mips : <|opcode|address|>
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
class FJ<bits<6> op> : StdArch class FJ<bits<6> op> : StdArch
{ {
bits<26> target; bits<26> target;
bits<32> Inst; bits<32> Inst;
▲ Show 20 Lines • Show All 493 Lines • ▼ Show 20 Lines
// funct - combined with opcode field give us an operation code. // funct - combined with opcode field give us an operation code.
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Format FI instruction class in Mips : <|opcode|base|ft|immediate|> // Format FI instruction class in Mips : <|opcode|base|ft|immediate|>
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
class FFI<bits<6> op, dag outs, dag ins, string asmstr, list<dag> pattern>:
InstSE<outs, ins, asmstr, pattern, NoItinerary, FrmFI>
{
bits<5> ft;
bits<5> base;
bits<16> imm16;
let Opcode = op;
let Inst{25-21} = base;
let Inst{20-16} = ft;
let Inst{15-0} = imm16;
}
class ADDS_FM<bits<6> funct, bits<5> fmt> : StdArch { class ADDS_FM<bits<6> funct, bits<5> fmt> : StdArch {
bits<5> fd; bits<5> fd;
bits<5> fs; bits<5> fs;
bits<5> ft; bits<5> ft;
bits<32> Inst; bits<32> Inst;
let Inst{31-26} = 0x11; let Inst{31-26} = 0x11;
▲ Show 20 Lines • Show All 259 Lines • Show Last 20 Lines