Page MenuHomePhabricator

[mlir][spirv] NFC: expose builtin func op conversion pattern
ClosedPublic

Authored by antiagainst on Jan 25 2020, 2:05 PM.

Details

Summary

This commit exposes the func op conversion pattern via a new
populateBuiltinFuncToSPIRVPatterns function from the standard
to SPIR-V conversion passs. This is structurally better given
that func op belongs to the builtin dialect. More importantly,
this makes the pattern reusable to other dialect to SPIR-V
dialect conversion as other dialect can well adopt builtin
func op instead of having its own. Besides, it's very common
to use func ops as test wrappers in lit tests, so test passes
will need to handle func ops too.

Diff Detail

Event Timeline

antiagainst created this revision.Jan 25 2020, 2:05 PM

Unit tests: pass. 62195 tests passed, 0 failed and 815 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

benvanik accepted this revision.Jan 25 2020, 4:01 PM
This revision is now accepted and ready to land.Jan 25 2020, 4:01 PM
This revision was automatically updated to reflect the committed changes.