This is an archive of the discontinued LLVM Phabricator instance.

Cast to (const OptionPermissions*) to avoid warning.
ClosedPublic

Authored by brucem on Feb 2 2015, 3:11 AM.

Download Raw Diff

Details

Reviewers

Commits

rGfd3cd13af565: Cast to (const OptionPermissions*) to avoid warning.
rLLDB227951: Cast to (const OptionPermissions*) to avoid warning.
rL227951: Cast to (const OptionPermissions*) to avoid warning.

Diff Detail

Event Timeline

brucem updated this revision to Diff 19142.Feb 2 2015, 3:11 AM

brucem retitled this revision from to Cast to (const OptionPermissions*) to avoid warning..

brucem updated this object.

brucem edited the test plan for this revision. (Show Details)

brucem added a reviewer: clayborg.

brucem added a subscriber: Unknown Object (MLST).

Looks good.

This revision is now accepted and ready to land.Feb 2 2015, 9:59 AM

brucem closed this revision.Feb 2 2015, 11:54 PM

Revision Contents

Path

Size

source/

Commands/

CommandObjectPlatform.cpp

4 lines

Diff 19142

source/Commands/CommandObjectPlatform.cpp

Show First 20 Lines • Show All 610 Lines • ▼ Show 20 Lines	public:
DoExecute (Args& args, CommandReturnObject &result)		DoExecute (Args& args, CommandReturnObject &result)
{		{
PlatformSP platform_sp (m_interpreter.GetDebugger().GetPlatformList().GetSelectedPlatform());		PlatformSP platform_sp (m_interpreter.GetDebugger().GetPlatformList().GetSelectedPlatform());
if (platform_sp)		if (platform_sp)
{		{
std::string cmd_line;		std::string cmd_line;
args.GetCommandString(cmd_line);		args.GetCommandString(cmd_line);
uint32_t mode;		uint32_t mode;
const OptionPermissions* options_permissions = (OptionPermissions*)m_options.GetGroupWithOption('r');		const OptionPermissions* options_permissions = (const OptionPermissions*)m_options.GetGroupWithOption('r');
if (options_permissions)		if (options_permissions)
mode = options_permissions->m_permissions;		mode = options_permissions->m_permissions;
else		else
mode = lldb::eFilePermissionsUserRWX \| lldb::eFilePermissionsGroupRWX \| lldb::eFilePermissionsWorldRX;		mode = lldb::eFilePermissionsUserRWX \| lldb::eFilePermissionsGroupRWX \| lldb::eFilePermissionsWorldRX;
Error error = platform_sp->MakeDirectory(cmd_line.c_str(), mode);		Error error = platform_sp->MakeDirectory(cmd_line.c_str(), mode);
if (error.Success())		if (error.Success())
{		{
result.SetStatus (eReturnStatusSuccessFinishResult);		result.SetStatus (eReturnStatusSuccessFinishResult);
▲ Show 20 Lines • Show All 52 Lines • ▼ Show 20 Lines	public:
{		{
PlatformSP platform_sp (m_interpreter.GetDebugger().GetPlatformList().GetSelectedPlatform());		PlatformSP platform_sp (m_interpreter.GetDebugger().GetPlatformList().GetSelectedPlatform());
if (platform_sp)		if (platform_sp)
{		{
Error error;		Error error;
std::string cmd_line;		std::string cmd_line;
args.GetCommandString(cmd_line);		args.GetCommandString(cmd_line);
mode_t perms;		mode_t perms;
const OptionPermissions* options_permissions = (OptionPermissions*)m_options.GetGroupWithOption('r');		const OptionPermissions* options_permissions = (const OptionPermissions*)m_options.GetGroupWithOption('r');
if (options_permissions)		if (options_permissions)
perms = options_permissions->m_permissions;		perms = options_permissions->m_permissions;
else		else
perms = lldb::eFilePermissionsUserRW \| lldb::eFilePermissionsGroupRW \| lldb::eFilePermissionsWorldRead;		perms = lldb::eFilePermissionsUserRW \| lldb::eFilePermissionsGroupRW \| lldb::eFilePermissionsWorldRead;
lldb::user_id_t fd = platform_sp->OpenFile(FileSpec(cmd_line.c_str(),false),		lldb::user_id_t fd = platform_sp->OpenFile(FileSpec(cmd_line.c_str(),false),
File::eOpenOptionRead \| File::eOpenOptionWrite \|		File::eOpenOptionRead \| File::eOpenOptionWrite \|
File::eOpenOptionAppend \| File::eOpenOptionCanCreate,		File::eOpenOptionAppend \| File::eOpenOptionCanCreate,
perms,		perms,
▲ Show 20 Lines • Show All 1,606 Lines • Show Last 20 Lines