This is an archive of the discontinued LLVM Phabricator instance.

GlobalISel: Reimplement widenScalar for G_UNMERGE_VALUES results
ClosedPublic

Authored by arsenm on Jan 21 2020, 7:58 AM.

Details

Summary

Only use shifts if the requested type exactly matches the source type,
and create sub-unmerges otherwise.

Diff Detail

Event Timeline

arsenm created this revision.Jan 21 2020, 7:58 AM
aemerson accepted this revision.Jan 26 2020, 9:55 PM

LGTM with additional comment.

llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
1476

A comment would be useful here explaining what this is trying to achieve.

This revision is now accepted and ready to land.Jan 26 2020, 9:55 PM