Index: llvm/trunk/lib/Transforms/InstCombine/InstCombineCasts.cpp =================================================================== --- llvm/trunk/lib/Transforms/InstCombine/InstCombineCasts.cpp +++ llvm/trunk/lib/Transforms/InstCombine/InstCombineCasts.cpp @@ -1064,6 +1064,15 @@ Value *Src = CI.getOperand(0); Type *SrcTy = Src->getType(), *DestTy = CI.getType(); + // If we know that the value being extended is positive, we can use a zext + // instead. + bool KnownZero, KnownOne; + ComputeSignBit(Src, KnownZero, KnownOne, 0, &CI); + if (KnownZero) { + Value *ZExt = Builder->CreateZExt(Src, DestTy); + return ReplaceInstUsesWith(CI, ZExt); + } + // Attempt to extend the entire input expression tree to the destination // type. Only do this if the dest type is a simple type, don't convert the // expression tree to something weird like i93 unless the source is also Index: llvm/trunk/test/Transforms/InstCombine/gep-sext.ll =================================================================== --- llvm/trunk/test/Transforms/InstCombine/gep-sext.ll +++ llvm/trunk/test/Transforms/InstCombine/gep-sext.ll @@ -0,0 +1,61 @@ +; RUN: opt < %s -instcombine -S | FileCheck %s +target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64" +target triple = "x86_64-pc-win32" + +declare void @use(i32) readonly + +; We prefer to canonicalize the machine width gep indices early +define void @test(i32* %p, i32 %index) { +; CHECK-LABEL: @test +; CHECK-NEXT: %1 = sext i32 %index to i64 +; CHECK-NEXT: %addr = getelementptr i32* %p, i64 %1 + %addr = getelementptr i32* %p, i32 %index + %val = load i32* %addr + call void @use(i32 %val) + ret void +} +; If they've already been canonicalized via zext, that's fine +define void @test2(i32* %p, i32 %index) { +; CHECK-LABEL: @test2 +; CHECK-NEXT: %i = zext i32 %index to i64 +; CHECK-NEXT: %addr = getelementptr i32* %p, i64 %i + %i = zext i32 %index to i64 + %addr = getelementptr i32* %p, i64 %i + %val = load i32* %addr + call void @use(i32 %val) + ret void +} +; If we can use a zext, we prefer that. This requires +; knowing that the index is positive. +define void @test3(i32* %p, i32 %index) { +; CHECK-LABEL: @test3 +; CHECK: zext +; CHECK-NOT: sext + %addr_begin = getelementptr i32* %p, i64 40 + %addr_fixed = getelementptr i32* %addr_begin, i64 48 + %val_fixed = load i32* %addr_fixed, !range !0 + %addr = getelementptr i32* %addr_begin, i32 %val_fixed + %val = load i32* %addr + call void @use(i32 %val) + ret void +} +; Replace sext with zext where possible +define void @test4(i32* %p, i32 %index) { +; CHECK-LABEL: @test4 +; CHECK: zext +; CHECK-NOT: sext + %addr_begin = getelementptr i32* %p, i64 40 + %addr_fixed = getelementptr i32* %addr_begin, i64 48 + %val_fixed = load i32* %addr_fixed, !range !0 + %i = sext i32 %val_fixed to i64 + %addr = getelementptr i32* %addr_begin, i64 %i + %val = load i32* %addr + call void @use(i32 %val) + ret void +} + +;; !range !0 +!0 = !{i32 0, i32 2147483647} + + +