This is an archive of the discontinued LLVM Phabricator instance.

Paths

Table of Contentst

-
libcxx/include/
-
include/
-
__config

Differential D71522

Define _LIBCPP_HAS_TIMESPEC_GET for FreeBSD when appropriate
ClosedPublic

Authored by dim on Dec 15 2019, 3:22 AM.

Download Raw Diff

Details

Reviewers

emaste
EricWF
ldionne
mclow.lists

Commits

rG1a5959196da0: Define _LIBCPP_HAS_TIMESPEC_GET for FreeBSD when appropriate
rG5e416ba943b7: Define _LIBCPP_HAS_TIMESPEC_GET for FreeBSD when appropriate

Summary

FreeBSD got timespec_get support somewhere in the 12.x timeframe, but
the C++ version check in its system headers was written incorrectly.
This has now been fixed for both FreeBSD 13 and 12.

Add checks for the corresponding __FreeBSD_version values, to define
_LIBCPP_HAS_TIMESPEC_GET when the function is supported.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

dim created this revision.Dec 15 2019, 3:22 AM

Herald added a project: Restricted Project. · View Herald TranscriptDec 15 2019, 3:22 AM

Herald added subscribers: dexonsmith, christof, krytarowski. · View Herald Transcript

dim edited the summary of this revision. (Show Details)Dec 15 2019, 3:24 AM

Harbormaster completed remote builds in B42522: Diff 233956.Dec 15 2019, 3:29 AM

ldionne accepted this revision.Jan 29 2020, 5:21 PM

This revision is now accepted and ready to land.Jan 29 2020, 5:21 PM

Herald added a subscriber: arichardson. · View Herald TranscriptJan 29 2020, 5:21 PM

Closed by commit rG5e416ba943b7: Define _LIBCPP_HAS_TIMESPEC_GET for FreeBSD when appropriate (authored by dim). · Explain WhyJan 29 2020, 11:03 PM

This revision was automatically updated to reflect the committed changes.

arichardson mentioned this in D94292: [libc++] Sync TEST_HAS_TIMESPEC_GET and _LIBCPP_HAS_TIMESPEC_GET on FreeBSD.Jan 8 2021, 3:45 AM

arichardson mentioned this in rG077a84f91140: [libc++] Sync TEST_HAS_TIMESPEC_GET and _LIBCPP_HAS_TIMESPEC_GET on FreeBSD.Jan 19 2021, 7:05 AM

Revision Contents

Path

Size

libcxx/

include/

__config

4 lines

Diff 241353

libcxx/include/__config

	Show First 20 Lines • Show All 336 Lines • ▼ Show 20 Lines
	# define _LIBCPP_NO_CFI			# define _LIBCPP_NO_CFI
	#endif			#endif

	#if __ISO_C_VISIBLE >= 2011 \|\| __cplusplus >= 201103L			#if __ISO_C_VISIBLE >= 2011 \|\| __cplusplus >= 201103L
	# if defined(__FreeBSD__)			# if defined(__FreeBSD__)
	# define _LIBCPP_HAS_ALIGNED_ALLOC			# define _LIBCPP_HAS_ALIGNED_ALLOC
	# define _LIBCPP_HAS_QUICK_EXIT			# define _LIBCPP_HAS_QUICK_EXIT
	# define _LIBCPP_HAS_C11_FEATURES			# define _LIBCPP_HAS_C11_FEATURES
				# if __FreeBSD_version >= 1300064 \|\| \
				(__FreeBSD_version >= 1201504 && __FreeBSD_version < 1300000)
				# define _LIBCPP_HAS_TIMESPEC_GET
				# endif
	# elif defined(__BIONIC__)			# elif defined(__BIONIC__)
	# define _LIBCPP_HAS_C11_FEATURES			# define _LIBCPP_HAS_C11_FEATURES
	# if __ANDROID_API__ >= 21			# if __ANDROID_API__ >= 21
	# define _LIBCPP_HAS_QUICK_EXIT			# define _LIBCPP_HAS_QUICK_EXIT
	# endif			# endif
	# if __ANDROID_API__ >= 28			# if __ANDROID_API__ >= 28
	# define _LIBCPP_HAS_ALIGNED_ALLOC			# define _LIBCPP_HAS_ALIGNED_ALLOC
	# endif			# endif
	▲ Show 20 Lines • Show All 1,176 Lines • Show Last 20 Lines