This is an archive of the discontinued LLVM Phabricator instance.

[SYCL] Add support for auxiliary triple specification to Frontend
ClosedPublic

Authored by bader on Dec 10 2019, 10:28 AM.

Details

Summary

Add host predefined macros to compilation for SYCL device, which is
required for pre-processing host specific includes (e.g. system
headers).

Diff Detail

Event Timeline

bader created this revision.Dec 10 2019, 10:28 AM
Herald added a project: Restricted Project. · View Herald Transcript

I'm looking for test suggestions as I was not able to find tests covering similar changes for OpenMP compiler.

https://github.com/llvm/llvm-project/commit/59d7b77b16bf11810091fe75a4348198783d3fbc modifies driver and front-end, but adds only driver tests.

Most probably, just missed the testing of the frontend part here

Build result: pass - 60674 tests passed, 0 failed and 726 were skipped.

Log files: console-log.txt, CMakeCache.txt

Most probably, just missed the testing of the frontend part here

Should I add test for both: SYCL and OpenMP?
What is the right place for this kind of tests: clang/test/Preprocessor/ or clang/test/Frontend/?

Most probably, just missed the testing of the frontend part here

Should I add test for both: SYCL and OpenMP?
What is the right place for this kind of tests: clang/test/Preprocessor/ or clang/test/Frontend/?

It would good but make in different patches. For OpenMP tests there is a directory clang/test/OpenMP. For SYCL, probably, clang/test/Frontend, since it is going to be a test for the frontend.

bader updated this revision to Diff 233303.Dec 11 2019, 3:09 AM

Added LIT test.

If it's okay, I'll add similar test for OpenMP device compiler to clang/test/OpenMP directory.

This revision is now accepted and ready to land.Dec 11 2019, 3:18 AM

Build result: pass - 60675 tests passed, 0 failed and 726 were skipped.

Log files: console-log.txt, CMakeCache.txt

This revision was automatically updated to reflect the committed changes.