[SimplifyCFG] propagate fast-math-flags (FMF) from phi to select

[spatel]

Summary

This is another step towards having FMF apply only to FP values rather than those + fcmp. See PR38086 for one of the original discussions/motivations:
https://bugs.llvm.org/show_bug.cgi?id=38086

And the test here is derived from PR39535:
https://bugs.llvm.org/show_bug.cgi?id=39535

Currently, we lose FMF when converting any phi to select in SimplifyCFG. There are a small number of similar changes needed to correct within SimplifyCFG, so it should be quick to patch this pass up.

FMF was extended to select and phi with:
D61917
D67564

[cameron.mcinally]

LGTM

llvm/lib/Transforms/Utils/SimplifyCFG.cpp

1416

Have we considered adding a CreateSelectFMF(...)? It could be a little weird though, since CreateSelect(...) handles both Int and FP...

[spatel]

llvm/lib/Transforms/Utils/SimplifyCFG.cpp

1416

I hadn't thought of that, but that's a possibility. We could assert that if an optional FMF was passed to the builder as a parameter that the select actually is an FPMathOperator.

llvm/lib/Transforms/Utils/SimplifyCFG.cpp

for (PHINode &PN : Succ->phis()) {
       Value *BB1V = PN.getIncomingValueForBlock(BB1);
       Value *BB2V = PN.getIncomingValueForBlock(BB2);
       if (BB1V == BB2V)
         continue;
 
       // These values do not agree.  Insert a select instruction before NT
       // that determines the right value.
       SelectInst *&SI = InsertedSelects[std::make_pair(BB1V, BB2V)];
-      if (!SI)
+      if (!SI) {
+        // Propagate fast-math-flags from phi node to its replacement select.
+        IRBuilder<>::FastMathFlagGuard FMFGuard(Builder);
+        if (isa<FPMathOperator>(PN))
+          Builder.setFastMathFlags(PN.getFastMathFlags());
+
         SI = cast<SelectInst>(
             Builder.CreateSelect(BI->getCondition(), BB1V, BB2V,
                                  BB1V->getName() + "." + BB2V->getName(), BI));
+      }
 
       // Make the PHI node use the select for all incoming values for BB1/BB2
       for (unsigned i = 0, e = PN.getNumIncomingValues(); i != e; ++i)
         if (PN.getIncomingBlock(i) == BB1 || PN.getIncomingBlock(i) == BB2)
           PN.setIncomingValue(i, SI);
     }
   }
 

llvm/test/Transforms/SimplifyCFG/HoistCode.ll

F:              ; preds = %0
   store i32 7, i32* %P
   ret void
 }
 
 define float @PR39535min(float %x) {
 ; CHECK-LABEL: @PR39535min(
 ; CHECK-NEXT:  entry:
 ; CHECK-NEXT:    [[TOBOOL:%.*]] = fcmp une float [[X:%.*]], 0.000000e+00
-; CHECK-NEXT:    [[DOTX:%.*]] = select i1 [[TOBOOL]], float 0.000000e+00, float [[X]]
+; CHECK-NEXT:    [[DOTX:%.*]] = select fast i1 [[TOBOOL]], float 0.000000e+00, float [[X]]
 ; CHECK-NEXT:    ret float [[DOTX]]
 ;
 entry:
   %tobool = fcmp une float %x, 0.0
   br i1 %tobool, label %cond.true, label %cond.false
 
 cond.true:
   br label %cond.end
 
 cond.false:
   br label %cond.end
 
 cond.end:
   %cond = phi fast float [ 0.0, %cond.true ], [ %x, %cond.false ]
   ret float %cond
 }