This is an archive of the discontinued LLVM Phabricator instance.

[X86] Bugfix for rL349334
ClosedPublic

Authored by yubing on Nov 7 2019, 10:13 PM.

Details

Summary

Since the width of a bit field cannot exceed the width of the underlying type, we should change fraction's type to long long for ia32.

Diff Detail

Event Timeline

yubing created this revision.Nov 7 2019, 10:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 7 2019, 10:13 PM
RKSimon added inline comments.Nov 8 2019, 2:08 AM
SingleSource/UnitTests/Vector/AVX512F/getmant.c
119–121

Have you confirmed this works? Would it be better to change all 3 members to use unsigned long long?

yubing updated this revision to Diff 228789.Nov 11 2019, 5:35 PM
yubing marked an inline comment as done.
RKSimon accepted this revision.Nov 12 2019, 6:17 AM

LGTM - cheers

This revision is now accepted and ready to land.Nov 12 2019, 6:17 AM