Page MenuHomePhabricator

[clang] [cmake] Use add_clang_tool() to install all tools
ClosedPublic

Authored by mgorny on Oct 3 2019, 3:03 PM.

Details

Summary

Switch clang-check, clang-extdef-mapping and clang-offload-bundler
to use add_clang_tool() rather than add_clang_executable() with a custom
install rule. This makes them LLVM_DISTRIBUTION_COMPONENTS-friendly.

Diff Detail

Repository
rL LLVM

Event Timeline

mgorny created this revision.Oct 3 2019, 3:03 PM
beanz added a comment.Oct 3 2019, 4:53 PM

Are these tools intended to be installed? I thought they were developer focused tools. I don't think we should make install targets for things that the project doesn't want to support publicly.

This also changes the behavior of the install target to include these extra tools, which will increase the size of installs that many people are using today with these tools. At the very least if we go down this direction we need to add some option like LLVM_INSTALL_TOOLCHAIN_ONLY so that we don't radically alter the current install behavior.

Well, they were installed for me, and all of them certainly have install() command right now. Not sure if there's some high magic making install() implicitly not install stuff here ;-).

beanz accepted this revision.Oct 4 2019, 1:12 PM

fair enough

This revision is now accepted and ready to land.Oct 4 2019, 1:12 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptOct 4 2019, 1:29 PM