[LNT] Sort machines by ID as expected by test case

[hubert.reinterpretcast]

Summary

tests/lnttool/admin.shtest fails in some environments because it expects the list-machines output in a certain order.

Assuming ascending order, the matching sort would be the one based on the id. In particular, "localhost" follows "LNT" in both ASCII strcmp and also with case-insensitive sorting, and the test expects "localhost" first.

I'm open to doing the sorting on the client side, but this patch sorts on the server side mainly to demonstrate that the expectation of the test was unwarranted given the state of the code. Sorting on the server side also benefits all clients, as opposed to just the ones that are part of this package.

[thopre]

Alternatively the test could use -DAG directives. But I do think sorting is nicer as it's easier to find a machine in a long list and doing it on the server side sounds sensible to me. I'll let Chris have the last word though.

[hubert.reinterpretcast]

In D67884#1678058, @thopre wrote:

Alternatively the test could use -DAG directives. But I do think sorting is nicer as it's easier to find a machine in a long list and doing it on the server side sounds sensible to me. I'll let Chris have the last word though.

@cmatthews, pinging for your opinion.

[cmatthews]

Yeah, this LGTM.

lnt/trunk/lnt/server/ui/api.py

 class Machines(Resource):
     """List all the machines and give summary information."""
     method_decorators = [in_db]
 
     @staticmethod
     def get():
         ts = request.get_testsuite()
         session = request.session
-        machines = session.query(ts.Machine).all()
+        machines = session.query(ts.Machine).order_by(ts.Machine.id).all()
 
         result = common_fields_factory()
         result['machines'] = machines
         return result
 
 
 class Machine(Resource):
     """Detailed results about a particular machine, including runs on it."""