This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Make input/output args analyzing functions public
AbandonedPublic

Authored by wwei on Jul 24 2019, 9:18 AM.

Details

Summary

To support CallLowering for GlobalIsel, and reduce duplicated code as much as possible, we change the C++ access specifiers from private to public for analyzeInputArgs and analyzeOutputArgs functions. Thus, GlobalIsel can reuse these two functions to support call and return lowering.

Diff Detail

Event Timeline

wwei created this revision.Jul 24 2019, 9:18 AM

Please can you merge this into D65219, given these changes are relevant to that patch? It's hard to know if these changes are "correct" without the context of that patch.

wwei added a comment.Jul 29 2019, 8:23 AM

Please can you merge this into D65219, given these changes are relevant to that patch? It's hard to know if these changes are "correct" without the context of that patch.

@lenary I would close this patch, and the change in this patch will be merged into another patch about general calllowering support for GlobalIsel. (D65219 is an initial skeleton for GlobalISel, it should not have un-relevant code.)

Please can you merge this into D65219, given these changes are relevant to that patch? It's hard to know if these changes are "correct" without the context of that patch.

@lenary I would close this patch, and the change in this patch will be merged into another patch about general calllowering support for GlobalIsel. (D65219 is an initial skeleton for GlobalISel, it should not have un-relevant code.)

Ok, That sounds sensible :)

wwei abandoned this revision.Jul 29 2019, 6:25 PM