Index: lib/CodeGen/MachineVerifier.cpp =================================================================== --- lib/CodeGen/MachineVerifier.cpp +++ lib/CodeGen/MachineVerifier.cpp @@ -1507,6 +1507,16 @@ report("Explicit operand marked as implicit", MO, MONum); } + // Check that a target instruction has register operands only as expected. + if (!TII->isGenericOpcode(MO->getParent()->getOpcode())) { + if (MCOI.OperandType == MCOI::OPERAND_REGISTER && + (!MO->isReg() && !MO->isFI())) + report("Expected a register operand.", MO, MONum); + if ((MCOI.OperandType == MCOI::OPERAND_IMMEDIATE || + MCOI.OperandType == MCOI::OPERAND_PCREL) && MO->isReg()) + report("Expected a non-register operand.", MO, MONum); + } + int TiedTo = MCID.getOperandConstraint(MONum, MCOI::TIED_TO); if (TiedTo != -1) { if (!MO->isReg()) Index: test/MachineVerifier/verify-targetops.mir =================================================================== --- /dev/null +++ test/MachineVerifier/verify-targetops.mir @@ -0,0 +1,36 @@ +# RUN: not llc -march=x86 -o - %s -start-after=finalize-isel -verify-machineinstrs \ +# RUN: 2>&1 | FileCheck %s +# +# Check that MachineVerifier catches corrupt operands where MO->isReg() +# returns true, but the descriptor says it should be an OPERAND_IMMEDIATE or +# OPERAND_PCREL. Conversely, if MO->isReg() (and MO->isFI()) returns false, +# check that not an OPERAND_REGISTER is expected. + +# CHECK-LABEL: fun + +# CHECK: *** Bad machine code: Expected a register operand. *** +# CHECK: - instruction: %1:gr32 = XOR32rm -1, %fixed-stack.1, 1, $noreg, 0, $noreg, implicit-def dead $eflags :: (load 4 from %fixed-stack.1, align 8) +# CHECK: - operand 1: -1 + +# CHECK: *** Bad machine code: Expected a non-register operand. *** +# CHECK: - instruction: %2:gr32 = OR32ri %1:gr32(tied-def 0), %0:gr32, implicit-def dead $eflags +# CHECK: - operand 2: %0:gr32 + + +name: fun +tracksRegLiveness: true +fixedStack: + - { id: 1, offset: 8, size: 4, alignment: 8, isImmutable: true } + - { id: 3, size: 4, alignment: 16, isImmutable: true } +body: | + bb.0: + %0:gr32 = MOV32rm %fixed-stack.3, 1, $noreg, 0, $noreg :: (load 4 from %fixed-stack.3, align 16) + ; Was: %1:gr32 = XOR32rm %0, %fixed-stack.1, 1, $noreg, 0, $noreg, implicit-def dead $eflags :: (load 4 from %fixed-stack.1, align 8) + %1:gr32 = XOR32rm -1, %fixed-stack.1, 1, $noreg, 0, $noreg, implicit-def dead $eflags :: (load 4 from %fixed-stack.1, align 8) + ; Was: %2:gr32 = OR32ri %1, -256, implicit-def dead $eflags + %2:gr32 = OR32ri %1, %0, implicit-def dead $eflags + %3:gr32 = MOV32ri -1 + $eax = COPY %2 + $edx = COPY %3 + RET 0, $eax, $edx +...