This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Update comments in asan header to doxygen format; NFC.
ClosedPublic

Authored by pgousseau on May 22 2019, 4:32 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

pgousseau created this revision.May 22 2019, 4:32 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 22 2019, 4:32 AM
Herald added subscribers: Restricted Project, llvm-commits, dberris. · View Herald Transcript
jdoerfert accepted this revision.Jun 2 2019, 11:40 AM
jdoerfert added a subscriber: jdoerfert.

I think adding all these comments and updating the format is a great thing!

Minor comments to consider:

  • I thought we used backslash instead of @ now but I might be wrong. The coding standard uses backslashs, if compiler-rt is not using @ all over the place you should change it.
  • Mention in the commit message that you also add descriptions to undocumented functions.
  • Mention in the commit message that you improved spelling, grammar, and formatting as well.

I'm not a compiler-rt person but if there is no objection in the next few days, you should go ahead (LGTM).

This revision is now accepted and ready to land.Jun 2 2019, 11:40 AM
pgousseau updated this revision to Diff 202682.Jun 3 2019, 3:09 AM

Replaced doxygen's '@' character by '\'

I think adding all these comments and updating the format is a great thing!

Minor comments to consider:

  • I thought we used backslash instead of @ now but I might be wrong. The coding standard uses backslashs, if compiler-rt is not using @ all over the place you should change it.
  • Mention in the commit message that you also add descriptions to undocumented functions.
  • Mention in the commit message that you improved spelling, grammar, and formatting as well.

I'm not a compiler-rt person but if there is no objection in the next few days, you should go ahead (LGTM).

Sounds good, yes '@' is not used at all in compiler-rt doxygen comments, I have replaced with '\'. Thanks!

This revision was automatically updated to reflect the committed changes.