This is an archive of the discontinued LLVM Phabricator instance.

Differential D60210

llvm-undname: Name a pair. No behavior change.
ClosedPublic

Authored by thakis on Apr 3 2019, 9:16 AM.

Details

Reviewers
zturner
Commits
rGc5615c232685: llvm-undname: Name a pair. No behavior change.
rL357653: llvm-undname: Name a pair. No behavior change.

Diff Detail

Repository
rL LLVM

Event Timeline

thakis created this revision.Apr 3 2019, 9:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2019, 9:16 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
zturner accepted this revision.Apr 3 2019, 2:42 PM
This revision is now accepted and ready to land.Apr 3 2019, 2:42 PM
Closed by commit rL357653: llvm-undname: Name a pair. No behavior change. (authored by nico). · Explain WhyApr 3 2019, 4:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
lib/
Demangle/
8 lines

Diff 193628

llvm/trunk/lib/Demangle/MicrosoftDemangle.cpp

Show First 20 Lines • Show All 1,321 Lines • ▼ Show 20 Lines
} }
NamedIdentifierNode * NamedIdentifierNode *
Demangler::demangleLocallyScopedNamePiece(StringView &MangledName) { Demangler::demangleLocallyScopedNamePiece(StringView &MangledName) {
assert(startsWithLocalScopePattern(MangledName)); assert(startsWithLocalScopePattern(MangledName));
NamedIdentifierNode *Identifier = Arena.alloc<NamedIdentifierNode>(); NamedIdentifierNode *Identifier = Arena.alloc<NamedIdentifierNode>();
MangledName.consumeFront('?'); MangledName.consumeFront('?');
auto Number = demangleNumber(MangledName); uint64_t Number = 0;
assert(!Number.second); bool IsNegative = false;
std::tie(Number, IsNegative) = demangleNumber(MangledName);
assert(!IsNegative);
// One ? to terminate the number // One ? to terminate the number
MangledName.consumeFront('?'); MangledName.consumeFront('?');
assert(!Error); assert(!Error);
Node *Scope = parse(MangledName); Node *Scope = parse(MangledName);
if (Error) if (Error)
return nullptr; return nullptr;
// Render the parent symbol's name into a buffer. // Render the parent symbol's name into a buffer.
OutputStream OS; OutputStream OS;
if (!initializeOutputStream(nullptr, nullptr, OS, 1024)) if (!initializeOutputStream(nullptr, nullptr, OS, 1024))
// FIXME: Propagate out-of-memory as an error? // FIXME: Propagate out-of-memory as an error?
std::terminate(); std::terminate();
OS << '`'; OS << '`';
Scope->output(OS, OF_Default); Scope->output(OS, OF_Default);
OS << '\''; OS << '\'';
OS << "::`" << Number.first << "'"; OS << "::`" << Number << "'";
OS << '\0'; OS << '\0';
char *Result = OS.getBuffer(); char *Result = OS.getBuffer();
Identifier->Name = copyString(Result); Identifier->Name = copyString(Result);
std::free(Result); std::free(Result);
return Identifier; return Identifier;
} }
// Parses a type name in the form of A@B@C@@ which represents C::B::A. // Parses a type name in the form of A@B@C@@ which represents C::B::A.
▲ Show 20 Lines • Show All 873 Lines • Show Last 20 Lines