This is an archive of the discontinued LLVM Phabricator instance.

Add skipFunction to PostRA machine sinking pass.
ClosedPublic

Authored by trentxintong on Feb 6 2019, 2:17 PM.

Download Raw Diff

Details

Reviewers

junbuml
arsenm

Commits

rG2d84c00dfa53: Add skipFunction to PostRA machine sinking pass.
rL354541: Add skipFunction to PostRA machine sinking pass.

Summary

Add skipFunction to PostRA machine sinking pass.

Diff Detail

Repository: rL LLVM

Event Timeline

trentxintong created this revision.Feb 6 2019, 2:17 PM

Herald added a project: Restricted Project. · View Herald TranscriptFeb 6 2019, 2:17 PM

Harbormaster completed remote builds in B27842: Diff 185643.Feb 6 2019, 2:17 PM

LGTM, test would be nice though

Address @arsenm comment by adding a test case. Thanks !

Herald added a subscriber: javed.absar. · View Herald TranscriptFeb 18 2019, 7:32 PM

Harbormaster completed remote builds in B28264: Diff 187292.Feb 18 2019, 7:33 PM

trentxintong added a reviewer: arsenm.Feb 20 2019, 5:58 PM

Herald added a subscriber: wdng. · View Herald TranscriptFeb 20 2019, 5:58 PM

LGTM

test/CodeGen/AArch64/bisect-post-ra-machine-sink.mir
9 ↗	(On Diff #187292)	This shouldn't use label
11 ↗	(On Diff #187292)	Or this
17 ↗	(On Diff #187292)	Or this
19 ↗	(On Diff #187292)	Or this

This revision is now accepted and ready to land.Feb 20 2019, 6:01 PM

Closed by commit rL354541: Add skipFunction to PostRA machine sinking pass. (authored by trentxintong). · Explain WhyFeb 20 2019, 6:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

llvm/

trunk/

lib/

CodeGen/

MachineSink.cpp

3 lines

test/

CodeGen/

AArch64/

bisect-post-ra-machine-sink.mir

40 lines

Diff 187709

llvm/trunk/lib/CodeGen/MachineSink.cpp

Show First 20 Lines • Show All 1,196 Lines • ▼ Show 20 Lines	for (auto I = CurBB.rbegin(), E = CurBB.rend(); I != E;) {

Changed = true;		Changed = true;
++NumPostRACopySink;		++NumPostRACopySink;
}		}
return Changed;		return Changed;
}		}

bool PostRAMachineSinking::runOnMachineFunction(MachineFunction &MF) {		bool PostRAMachineSinking::runOnMachineFunction(MachineFunction &MF) {
		if (skipFunction(MF.getFunction()))
		return false;

bool Changed = false;		bool Changed = false;
const TargetRegisterInfo *TRI = MF.getSubtarget().getRegisterInfo();		const TargetRegisterInfo *TRI = MF.getSubtarget().getRegisterInfo();
const TargetInstrInfo *TII = MF.getSubtarget().getInstrInfo();		const TargetInstrInfo *TII = MF.getSubtarget().getInstrInfo();

ModifiedRegUnits.init(*TRI);		ModifiedRegUnits.init(*TRI);
UsedRegUnits.init(*TRI);		UsedRegUnits.init(*TRI);
for (auto &BB : MF)		for (auto &BB : MF)
Changed \|= tryToSinkCopy(BB, MF, TRI, TII);		Changed \|= tryToSinkCopy(BB, MF, TRI, TII);

return Changed;		return Changed;
}		}

llvm/trunk/test/CodeGen/AArch64/bisect-post-ra-machine-sink.mir

				# RUN: llc -mtriple=aarch64-none-linux-gnu -run-pass=postra-machine-sink -verify-machineinstrs -o - %s \| FileCheck -check-prefix=RUN-POSTRA %s
				# RUN: llc -mtriple=aarch64-none-linux-gnu -run-pass=postra-machine-sink -opt-bisect-limit=0 -verify-machineinstrs -o - %s \| FileCheck -check-prefix=BISECT-NO-RUN-POSTRA %s

				---

				# Make sure the pass is run.
				# Sink w19 to %bb.1.
				# RUN-POSTRA-LABEL: name: sinkcopy1
				# RUN-POSTRA: bb.0:
				# RUN-POSTRA-NOT: $w19 = COPY killed $w0
				# RUN-POSTRA: bb.1:
				# RUN-POSTRA: liveins: $w1, $w0
				# RUN-POSTRA: renamable $w19 = COPY killed $w0

				# Make sure the pass it not run.
				# BISECT-NO-RUN-POSTRA-LABEL: name: sinkcopy1
				# BISECT-NO-RUN-POSTRA: bb.0:
				# BISECT-NO-RUN-POSTRA: $w19 = COPY killed $w0
				# BISECT-NO-RUN-POSTRA: bb.1:
				# BISECT-NO-RUN-POSTRA: liveins: $w1, $w19

				name: sinkcopy1
				tracksRegLiveness: true
				body: \|
				bb.0:
				liveins: $w0, $w1
				$w1 = SUBSWri $w1, 1, 0, implicit-def $nzcv
				renamable $w19 = COPY killed $w0
				Bcc 11, %bb.1, implicit $nzcv
				B %bb.2

				bb.1:
				liveins: $w1, $w19
				$w0 = ADDWrr $w1, $w19
				RET $x0

				bb.2:
				$w0 = COPY $wzr
				RET $x0
				...