This is an archive of the discontinued LLVM Phabricator instance.

[DA][NewPM] Add a printerpass and port the testsuite
ClosedPublic

Authored by philip.pfaffe on Jan 7 2019, 4:29 AM.

Details

Summary

The new-pm version of DA is untested. Testing requires a printer, so
add that and use it in the existing DA tests.

Diff Detail

Repository
rL LLVM

Event Timeline

philip.pfaffe created this revision.Jan 7 2019, 4:29 AM
dmgreen accepted this revision.Jan 8 2019, 5:38 AM

LGTM, with a couple of minor points.

llvm/include/llvm/Analysis/DependenceAnalysis.h
948 ↗(On Diff #180457)

class DependenceAnalysisPrinterPass

llvm/lib/Passes/PassRegistry.def
214 ↗(On Diff #180457)

These look like they should be in alphabetical ordering

This revision is now accepted and ready to land.Jan 8 2019, 5:38 AM
This revision was automatically updated to reflect the committed changes.