This is an archive of the discontinued LLVM Phabricator instance.

Minor cleanup of debug code
ClosedPublic

Authored by AndreyChurbanov on Nov 27 2018, 5:55 AM.

Download Raw Diff

Details

Reviewers

tlwilmar
jlpeyton
hbae

Commits

rG1ce776ea2ffe: [OpenMP] Minor cleanup of debug code
rOMP347801: [OpenMP] Minor cleanup of debug code
rL347801: [OpenMP] Minor cleanup of debug code

Summary

fixed calculation of string length;
removed NULL-check of pointer which has been dereferenced.

Diff Detail

Repository: rL LLVM

Event Timeline

AndreyChurbanov created this revision.Nov 27 2018, 5:55 AM

Herald added a subscriber: openmp-commits. · View Herald TranscriptNov 27 2018, 5:55 AM

LGTM

This revision is now accepted and ready to land.Nov 27 2018, 11:59 AM

Closed by commit rL347801: [OpenMP] Minor cleanup of debug code (authored by jlpeyton). · Explain WhyNov 28 2018, 12:20 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: llvm-commits. · View Herald TranscriptNov 28 2018, 12:20 PM

Revision Contents

Path

Size

openmp/

trunk/

runtime/

src/

kmp_settings.cpp

4 lines

Diff 175747

openmp/trunk/runtime/src/kmp_settings.cpp

	Show First 20 Lines • Show All 404 Lines • ▼ Show 20 Lines

	#ifdef KMP_DEBUG			#ifdef KMP_DEBUG
	static char *par_range_to_print = NULL;			static char *par_range_to_print = NULL;

	static void __kmp_stg_parse_par_range(char const name, char const value,			static void __kmp_stg_parse_par_range(char const name, char const value,
	int out_range, char out_routine,			int out_range, char out_routine,
	char out_file, int out_lb,			char out_file, int out_lb,
	int *out_ub) {			int *out_ub) {
	size_t len = KMP_STRLEN(value + 1);			size_t len = KMP_STRLEN(value) + 1;
	par_range_to_print = (char *)KMP_INTERNAL_MALLOC(len + 1);			par_range_to_print = (char *)KMP_INTERNAL_MALLOC(len + 1);
	KMP_STRNCPY_S(par_range_to_print, len + 1, value, len + 1);			KMP_STRNCPY_S(par_range_to_print, len + 1, value, len + 1);
	__kmp_par_range = +1;			__kmp_par_range = +1;
	__kmp_par_range_lb = 0;			__kmp_par_range_lb = 0;
	__kmp_par_range_ub = INT_MAX;			__kmp_par_range_ub = INT_MAX;
	for (;;) {			for (;;) {
	unsigned int len;			unsigned int len;
	if ((value == NULL) \|\| (*value == '\0')) {			if (*value == '\0') {
	break;			break;
	}			}
	if (!__kmp_strcasecmp_with_sentinel("routine", value, '=')) {			if (!__kmp_strcasecmp_with_sentinel("routine", value, '=')) {
	value = strchr(value, '=') + 1;			value = strchr(value, '=') + 1;
	len = __kmp_readstr_with_sentinel(out_routine, value,			len = __kmp_readstr_with_sentinel(out_routine, value,
	KMP_PAR_RANGE_ROUTINE_LEN - 1, ',');			KMP_PAR_RANGE_ROUTINE_LEN - 1, ',');
	if (len == 0) {			if (len == 0) {
	goto par_range_error;			goto par_range_error;
	▲ Show 20 Lines • Show All 5,361 Lines • Show Last 20 Lines