Index: include/llvm/Analysis/TargetTransformInfoImpl.h =================================================================== --- include/llvm/Analysis/TargetTransformInfoImpl.h +++ include/llvm/Analysis/TargetTransformInfoImpl.h @@ -807,15 +807,11 @@ return static_cast(this)->getCallCost(F, Arguments); } - if (const CastInst *CI = dyn_cast(U)) { - // Result of a cmp instruction is often extended (to be used by other - // cmp instructions, logical or return instructions). These are usually - // nop on most sane targets. - if (isa(CI->getOperand(0))) - return TTI::TCC_Free; - if (isa(CI) || isa(CI) || isa(CI)) - return static_cast(this)->getExtCost(CI, Operands.back()); - } + if (isa(U) || isa(U) || isa(U)) + // The old behaviour of generally treating extensions of icmp to be free + // has been removed. A target that needs it should override getUserCost(). + return static_cast(this)->getExtCost(cast(U), + Operands.back()); return static_cast(this)->getOperationCost( Operator::getOpcode(U), U->getType(), Index: test/Analysis/CostModel/SystemZ/ext-of-icmp-cost.ll =================================================================== --- /dev/null +++ test/Analysis/CostModel/SystemZ/ext-of-icmp-cost.ll @@ -0,0 +1,53 @@ +; RUN: opt < %s -cost-model -cost-kind=code-size -analyze \ +; RUN: -mtriple=s390x-unknown-linux -mcpu=z13 | FileCheck %s +; +; Check that getUserCost() does not return TCC_Free for extensions of +; i1 returned from icmp. + +define i64 @fun1(i64 %v) { +; CHECK-LABEL: 'fun1' +; CHECK: Cost Model: Found an estimated cost of 1 for instruction: %cmp = icmp eq i64 %v, 0 +; CHECK: Cost Model: Found an estimated cost of 1 for instruction: %z = zext i1 %cmp to i64 +; CHECK: Cost Model: Found an estimated cost of 1 for instruction: ret i64 %z + %cmp = icmp eq i64 %v, 0 + %z = zext i1 %cmp to i64 + ret i64 %z +} + +define i64 @fun2(i64 %v) { +; CHECK-LABEL: 'fun2' +; CHECK: Cost Model: Found an estimated cost of 1 for instruction: %cmp = icmp eq i64 %v, 0 +; CHECK: Cost Model: Found an estimated cost of 1 for instruction: %z = sext i1 %cmp to i64 +; CHECK: Cost Model: Found an estimated cost of 1 for instruction: ret i64 %z + %cmp = icmp eq i64 %v, 0 + %z = sext i1 %cmp to i64 + ret i64 %z +} + +define double @fun3(i64 %v) { +; CHECK-LABEL: 'fun3' +; CHECK: Cost Model: Found an estimated cost of 1 for instruction: %cmp = icmp eq i64 %v, 0 +; CHECK: Cost Model: Found an estimated cost of 1 for instruction: %z = uitofp i1 %cmp to double +; CHECK: Cost Model: Found an estimated cost of 1 for instruction: ret double %z + %cmp = icmp eq i64 %v, 0 + %z = uitofp i1 %cmp to double + ret double %z +} + +define double @fun4(i64 %v) { +; CHECK-LABEL: 'fun4' +; CHECK: Cost Model: Found an estimated cost of 1 for instruction: %cmp = icmp eq i64 %v, 0 +; CHECK: Cost Model: Found an estimated cost of 1 for instruction: %z = sitofp i1 %cmp to double +; CHECK: Cost Model: Found an estimated cost of 1 for instruction: ret double %z + %cmp = icmp eq i64 %v, 0 + %z = sitofp i1 %cmp to double + ret double %z +} + +define i64 @fun5(i1 %v) { +; CHECK-LABEL: 'fun5' +; CHECK: Cost Model: Found an estimated cost of 1 for instruction: %z = zext i1 %v to i64 +; CHECK: Cost Model: Found an estimated cost of 1 for instruction: ret i64 %z + %z = zext i1 %v to i64 + ret i64 %z +}