[analyzer] pr38072: Suppress an assertion failure for eliding the same destructor twice due to the default argument problem.
ClosedPublic
Actions

Authored by NoQ on Jul 11 2018, 6:30 PM.

Details

Reviewers

dcoughlin
xazax.hun
a.sidorin
george.karpenkov
szepet
rnkovacs

Commits

rG67d393f3d12e: [analyzer] Fix eliding the same destructor twice due to buggy default arguments.
rL338441: [analyzer] Fix eliding the same destructor twice due to buggy default arguments.
rC338441: [analyzer] Fix eliding the same destructor twice due to buggy default arguments.

Summary

@alexfh provided an example that demonstrates that elided copy constructors may get agglutinated due to improper control flow when default arguments are involved.

Suppress the assertion failure for now. Proper support is still an open problem.

Diff Detail

Repository: rC Clang

Event Timeline

NoQ created this revision.Jul 11 2018, 6:30 PM

Herald added subscribers: cfe-commits, mikhail.ramalho, baloghadamsoftware. · View Herald TranscriptJul 11 2018, 6:30 PM

NoQ added a parent revision: D49210: [CFG] [analyzer] NFC: Enumerate construction context layer kinds and re-use their code for ExprEngine keys..Jul 11 2018, 6:30 PM

NoQ added inline comments.

lib/StaticAnalyzer/Core/ExprEngine.cpp
434–435	Same problem here.

FTR, this is http://llvm.org/PR38072

LGTM with a nit.

test/Analysis/temporaries.cpp
472	// no-crash?

This revision is now accepted and ready to land.Jul 17 2018, 11:32 AM

Closed by commit rC338441: [analyzer] Fix eliding the same destructor twice due to buggy default arguments. (authored by NoQ). · Explain WhyJul 31 2018, 2:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

lib/

StaticAnalyzer/

Core/

ExprEngine.cpp

3 lines

test/

Analysis/

temporaries.cpp

15 lines

Diff 158384

View Options

lib/StaticAnalyzer/Core/ExprEngine.cpp