This is an archive of the discontinued LLVM Phabricator instance.

Differential D48758

Remove duplicated typedef in ilist.h
AbandonedPublic

Authored by lygstate on Jun 29 2018, 2:13 AM.

Details

Reviewers
chandlerc
Summary

Typedef iplist_impl_type twice(in Base Class and Sub Class) cause visual studio compiling failed in external projects.
Specifically (https://github.com/pytorch/glow).

The error looks like this:

“E:\CI-Cor-Ready\ai\face-live-detection\build\ALL_BUILD.vcxproj”(默认目标) (1) ->
“E:\CI-Cor-Ready\ai\face-live-detection\build\projects\glow\tests\unittests\BackendCorrectnessTest.vcxproj”(默认目标) (3) -
>
“E:\CI-Cor-Ready\ai\face-live-detection\build\projects\glow\lib\Backends\Backends.vcxproj”(默认目标) (4) ->
“E:\CI-Cor-Ready\ai\face-live-detection\build\projects\glow\lib\Backends\Interpreter\Interpreter.vcxproj”(默认目标) (5) ->
“E:\CI-Cor-Ready\ai\face-live-detection\build\projects\glow\lib\ExecutionEngine\ExecutionEngine.vcxproj”(默认目标) (6) ->
“E:\CI-Cor-Ready\ai\face-live-detection\build\projects\glow\lib\Optimizer\Optimizer.vcxproj”(默认目标) (7) ->
“E:\CI-Cor-Ready\ai\face-live-detection\build\projects\glow\lib\Quantization\Quantization.vcxproj”(默认目标) (8) ->
“E:\CI-Cor-Ready\ai\face-live-detection\build\projects\glow\lib\Graph\Graph.vcxproj”(默认目标) (14) ->
(ClCompile 目标) ->
  e:\ci-cor-ready\ai\face-live-detection\llvm\include\llvm\adt\ilist.h(405): error C4596: 'iplist_impl_type': illegal q
ualified name in member declaration (compiling source file E:\CI-Cor-Ready\ai\face-live-detection\build\projects\glow\A
utoGenInstr.cpp) [E:\CI-Cor-Ready\ai\face-live-detection\build\projects\glow\lib\Graph\Graph.vcxproj]
  e:\ci-cor-ready\ai\face-live-detection\llvm\include\llvm\adt\ilist.h(405): error C4596: 'iplist_impl_type': illegal q
ualified name in member declaration (compiling source file E:\CI-Cor-Ready\ai\face-live-detection\llvm\projects\glow\li
b\Graph\Graph.cpp) [E:\CI-Cor-Ready\ai\face-live-detection\build\projects\glow\lib\Graph\Graph.vcxproj]
  e:\ci-cor-ready\ai\face-live-detection\llvm\include\llvm\adt\ilist.h(405): error C4596: 'iplist_impl_type': illegal q
ualified name in member declaration (compiling source file E:\CI-Cor-Ready\ai\face-live-detection\build\projects\glow\A
utoGenIRBuilder.cpp) [E:\CI-Cor-Ready\ai\face-live-detection\build\projects\glow\lib\Graph\Graph.vcxproj]
  e:\ci-cor-ready\ai\face-live-detection\llvm\include\llvm\adt\ilist.h(405): error C4596: 'iplist_impl_type': illegal q
ualified name in member declaration (compiling source file E:\CI-Cor-Ready\ai\face-live-detection\llvm\projects\glow\li
b\Graph\Grad.cpp) [E:\CI-Cor-Ready\ai\face-live-detection\build\projects\glow\lib\Graph\Graph.vcxproj]
  e:\ci-cor-ready\ai\face-live-detection\llvm\include\llvm\adt\ilist.h(405): error C4596: 'iplist_impl_type': illegal q
ualified name in member declaration (compiling source file E:\CI-Cor-Ready\ai\face-live-detection\llvm\projects\glow\li
b\Graph\Node.cpp) [E:\CI-Cor-Ready\ai\face-live-detection\build\projects\glow\lib\Graph\Graph.vcxproj]
  e:\ci-cor-ready\ai\face-live-detection\llvm\include\llvm\adt\ilist.h(405): error C4596: 'iplist_impl_type': illegal q
ualified name in member declaration (compiling source file E:\CI-Cor-Ready\ai\face-live-detection\llvm\projects\glow\li
b\Graph\Nodes.cpp) [E:\CI-Cor-Ready\ai\face-live-detection\build\projects\glow\lib\Graph\Graph.vcxproj]

Diff Detail

Repository
rL LLVM

Event Timeline

lygstate created this revision.Jun 29 2018, 2:13 AM
Herald added subscribers: llvm-commits, dexonsmith. · View Herald TranscriptJun 29 2018, 2:13 AM
lygstate added a reviewer: chandlerc.Jun 29 2018, 2:30 AM
lygstate edited the summary of this revision. (Show Details)Jun 29 2018, 3:13 AM
lygstate edited the summary of this revision. (Show Details)
chandlerc requested changes to this revision.Jul 6 2018, 7:09 PM

What version of visual studio?

We have lots of build bots using MSVC and they aren't complaining about this. So I'm not sure where the source of the issue is, but I don't think it is this.

FWIW, C++ is totally fine with this kind of typedef.

This revision now requires changes to proceed.Jul 6 2018, 7:09 PM
lygstate added a comment.Jul 6 2018, 8:21 PM

How to close this review, I found the newest LLVM code have already resolve this problem.

chandlerc added a comment.Jul 6 2018, 8:29 PM

You can mark it as abandoned in Phabricator. Sorry for the (intermittent) problem!

lygstate abandoned this revision.Dec 26 2019, 1:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 26 2019, 1:00 AM
Herald added a subscriber: kristina. · View Herald Transcript

Revision Contents

PathSize
include/
llvm/
ADT/
1 line

Diff 153453

include/llvm/ADT/ilist.h

Context not available.
template <class T, class... Options> template <class T, class... Options>
class iplist class iplist
: public iplist_impl<simple_ilist<T, Options...>, ilist_traits<T>> { : public iplist_impl<simple_ilist<T, Options...>, ilist_traits<T>> {
typedef typename iplist::iplist_impl_type iplist_impl_type;
public: public:
iplist() = default; iplist() = default;
Context not available.