This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Fix test/CodeGen/RISCV/indirectbr.ll after D48202
AbandonedPublic

Authored by sabuasal on Jun 20 2018, 7:17 PM.

Details

Reviewers
asb
asbirlea
Summary

r335183 seems to accidentally have broken test/CodeGen/RISCV/indirectbr.ll

Diff Detail

Event Timeline

sabuasal created this revision.Jun 20 2018, 7:17 PM

Perhaps we should update the test to not rely on label names on the first place.

asbirlea accepted this revision.Jun 20 2018, 8:24 PM

I'm not clear why my testing didn't catch this test, but the label change looks exactly like what D48202 would change.
Appoving without retesting to unblock this.

This revision is now accepted and ready to land.Jun 20 2018, 8:24 PM
asb added a comment.Jun 21 2018, 1:39 AM

This was fixed in rL335202. In general, do feel free to direct commit minor test or build fixes without pre-commit review.

It seems that we really need to look at getting update_llc_test_checks.py to strip these label comments.

sabuasal abandoned this revision.Jun 27 2018, 2:19 PM