This is an archive of the discontinued LLVM Phabricator instance.

Fix lldb OS X build
ClosedPublic

Authored by loladiro on Aug 6 2014, 2:06 PM.

Details

Summary

Two changes:

  • The first is a new constant introduced in XCode 6, so we do the same thing as for CPU_SUBTYPE_X86_64_H
  • The second is small fix to the commit adding Host/Socket to make it build on OS X

Diff Detail

Repository
rL LLVM

Event Timeline

loladiro updated this revision to Diff 12250.Aug 6 2014, 2:06 PM
loladiro retitled this revision from to Fix lldb OS X build.
loladiro updated this object.
loladiro edited the test plan for this revision. (Show Details)
loladiro added a reviewer: zturner.
loladiro set the repository for this revision to rL LLVM.
loladiro added a subscriber: Unknown Object (MLST).
zturner edited edge metadata.Aug 6 2014, 2:10 PM

I don't know much about the ARM / cpu subtype change, but the socket change
is good, thanks for fixing that. Please submit the socket fix separately
from the other one though.

loladiro closed this revision.Aug 6 2014, 2:27 PM
loladiro updated this revision to Diff 12253.

Closed by commit rL214996 (authored by kfischer).