This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Implement FLT_ROUNDS macro
ClosedPublic

Authored by mbrase on Jun 11 2018, 3:25 PM.

Details

Summary

Addresses https://bugs.llvm.org/show_bug.cgi?id=25191

This patch adds AArch64 support for __builtin_flt_rounds() intrinsic by implementing custom lowering to compute it from the FPCR system register. I based this change heavily off of the implementation in the ARM backend.

Diff Detail

Event Timeline

mbrase created this revision.Jun 11 2018, 3:25 PM
t.p.northover accepted this revision.Jun 14 2018, 5:31 AM
t.p.northover added a subscriber: t.p.northover.

I think this looks reasonable to me.

This revision is now accepted and ready to land.Jun 14 2018, 5:31 AM

Thanks for reviewing this! I don't have commit access, can someone commit this for me?

Thanks for reviewing this! I don't have commit access, can someone commit this for me?

I'll push this later today! Thanks, Michael.

Sorry, I meant to do this a few days ago but forgot to actually commit and just rediscovered it today. It's pushed as r335118 now.