This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] [NFC] Remove unused Extensive diagnostic setting, rename AlternateExtensive to Extensive.
ClosedPublic

Authored by george.karpenkov on Jun 1 2018, 6:58 PM.

Details

Summary

In 2013, five years ago, we have switched to AlternateExtensive diagnostics by default, and Extensive was available under unused, undocumented flag. This change remove the flag, renames the Alternate diagnostic to Extensive (as it's no longer Alternate), and ports the test.

Diff Detail

Repository
rC Clang

Event Timeline

NoQ added a comment.Jun 4 2018, 5:13 PM

Thanks, that's been long overdue.

clang/include/clang/StaticAnalyzer/Core/BugReporter/PathDiagnostic.h
118–125 ↗(On Diff #149597)

Extra thanks.

NoQ accepted this revision.Jun 11 2018, 3:22 PM

Forgot to click accept.

This revision is now accepted and ready to land.Jun 11 2018, 3:22 PM
This revision was automatically updated to reflect the committed changes.
alexfh added a subscriber: alexfh.Jun 18 2018, 8:33 AM
alexfh added inline comments.
lib/StaticAnalyzer/Core/BugReporter.cpp
2613

Was this meant to be committed? I see this assertion firing on a ton of files.

@alexfh apologies, fixed.

Thank you1