This is an archive of the discontinued LLVM Phabricator instance.

Revert recently added MIR test (causes buildbot failures).
ClosedPublic

Authored by thanm on May 18 2018, 6:11 AM.

Details

Summary

Back out the new test test/CodeGen/X86/PR37310.mir, since it causes
check failures on one of the buildbots.

Diff Detail

Repository
rL LLVM

Event Timeline

thanm created this revision.May 18 2018, 6:11 AM
dyung added a subscriber: dyung.May 18 2018, 10:10 AM

I don't think that removing only the test (especially when there is only 1 test) is correct. You should probably either fix the test, or revert the entire commit and resubmit for review once you have fixed the test.

I don't think that removing only the test (especially when there is only 1 test) is correct. You should probably either fix the test, or revert the entire commit and resubmit for review once you have fixed the test.

Under most circumstances I think I would agree -- for example, if the change in question were introducing some new functionality whose behavior needed to be locked down.

In this case, the change is to avoid an assert in cases where you have an IR insanity (statically unreachable code) that is being created by an upstream pass-- there is no new behavior/functionality that needs checking, simply adding an additional guard to insure that the compiler doesn't crash when it sees this unexpected IR.

With that said, I'll go ahead and revert the whole thing.

This revision was not accepted when it landed; it landed in state Needs Review.May 18 2018, 10:51 AM
Closed by commit rL332742: Revert changes from D46265. (authored by thanm). · Explain Why
This revision was automatically updated to reflect the committed changes.
llvm/trunk/lib/CodeGen/StackColoring.cpp