[1/2] Fix path support on Windows

[zturner]

Summary

This is part one of a two part patch. This first part simply fixes the computation of the user's home directory, so that .lldbinit files are correctly loaded. A subsequent patch will fix issues related to the syntax differences in Windows and non-Windows paths (most notably with regards to the separator character).

[zturner]

Closed by commit rL214093 (authored by @zturner).

lldb/trunk/include/lldb/Host/Host.h

 #include <stdarg.h>
 
 #include <map>
 #include <string>
 
 #include "lldb/lldb-private.h"
 #include "lldb/Core/StringList.h"
 #include "lldb/Host/File.h"
+#include "lldb/Host/FileSpec.h"
 
 namespace lldb_private {
 
 //----------------------------------------------------------------------
 /// @class Host Host.h "lldb/Host/Host.h"
 /// @brief A class that provides host computer information.
 ///
 /// Host is a class that answers information about the host operating
public:
     ///
     /// @return
     ///     \b true if the thread name was able to be set, \b false
     ///     otherwise.
     static bool
     SetShortThreadName (lldb::pid_t pid, lldb::tid_t tid, const char *name, size_t len);
 
     //------------------------------------------------------------------
+    /// Gets the FileSpec of the user profile directory.  On Posix-platforms
+    /// this is ~, and on windows this is generally something like
+    /// C:\Users\Alice.
+    ///
+    /// @return
+    ///     \b A file spec with the path to the user's home directory.
+    //------------------------------------------------------------------
+    static FileSpec
+    GetUserProfileFileSpec ();
+
+    //------------------------------------------------------------------
     /// Gets the FileSpec of the current process (the process that
     /// that is running the LLDB code).
     ///
     /// @return
     ///     \b A file spec with the program name.
     //------------------------------------------------------------------
     static FileSpec
     GetProgramFileSpec ();

lldb/trunk/include/lldb/Host/windows/win32.h

 #include <time.h>
 
 // posix utilities
 int vasprintf(char **ret, const char *fmt, va_list ap);
 char * strcasestr(const char *s, const char* find);
 char* realpath(const char * name, char * resolved);
 
 #ifndef PATH_MAX
-#define PATH_MAX MAX_PATH
+#define PATH_MAX 32768
 #endif
 
 #define O_NOCTTY    0
 #define O_NONBLOCK  0
 #define SIGTRAP     5
 #define SIGKILL     9
 #define SIGSTOP     20
 

lldb/trunk/source/Host/common/Host.cpp

 #include "lldb/Host/Mutex.h"
 #include "lldb/Target/Process.h"
 #include "lldb/Target/TargetList.h"
 #include "lldb/Utility/CleanUp.h"
 
 #include "llvm/ADT/STLExtras.h"
 #include "llvm/ADT/SmallString.h"
 #include "llvm/Support/Host.h"
+#include "llvm/Support/Path.h"
 #include "llvm/Support/raw_ostream.h"
 
 #if defined (__APPLE__)
 #ifndef _POSIX_SPAWN_DISABLE_ASLR
 #define _POSIX_SPAWN_DISABLE_ASLR       0x0100
 #endif
 
 extern "C"
if (namebuflen > 0)
         return Host::SetThreadName (pid, tid, namebuf.get());
     }
     return false;
 }
 
 #endif
 
 FileSpec
+Host::GetUserProfileFileSpec ()
+{
+    static FileSpec g_profile_filespec;
+    if (!g_profile_filespec)
+    {
+        llvm::SmallString<64> path;
+        llvm::sys::path::home_directory(path);
+        return FileSpec(path.c_str(), false);
+    }
+    return g_profile_filespec;
+}
+
+FileSpec
 Host::GetProgramFileSpec ()
 {
     static FileSpec g_program_filespec;
     if (!g_program_filespec)
     {
 #if defined (__APPLE__)
         char program_fullpath[PATH_MAX];
         // If DST is NULL, then return the number of bytes needed.
#elif defined (__FreeBSD__) || defined (__FreeBSD_kernel__)
         size_t exe_path_size;
         if (sysctl(exe_path_mib, 4, NULL, &exe_path_size, NULL, 0) == 0)
         {
             char *exe_path = new char[exe_path_size];
             if (sysctl(exe_path_mib, 4, exe_path, &exe_path_size, NULL, 0) == 0)
                 g_program_filespec.SetFile(exe_path, false);
             delete[] exe_path;
         }
+#elif defined(_WIN32)
+        std::vector<char> buffer(PATH_MAX);
+        ::GetModuleFileName(NULL, &buffer[0], buffer.size());
+        g_program_filespec.SetFile(&buffer[0], false, FileSpec::ePathSyntaxWindows);
 #endif
     }
     return g_program_filespec;
 }
 
 #if !defined (__APPLE__) // see Host.mm
 
 bool

lldb/trunk/source/Interpreter/CommandInterpreter.cpp

CommandInterpreter::SourceInitFile (bool in_cwd, CommandReturnObject &result)
     else
     {
         // If we aren't looking in the current working directory we are looking
         // in the home directory. We will first see if there is an application
         // specific ".lldbinit" file whose name is "~/.lldbinit" followed by a 
         // "-" and the name of the program. If this file doesn't exist, we fall
         // back to just the "~/.lldbinit" file. We also obey any requests to not
         // load the init files.
-        const char *init_file_path = "~/.lldbinit";
+        FileSpec profilePath = Host::GetUserProfileFileSpec();
+        profilePath.AppendPathComponent(".lldbinit");
+        std::string init_file_path = profilePath.GetPath();
 
         if (m_skip_app_init_files == false)
         {
             FileSpec program_file_spec (Host::GetProgramFileSpec());
             const char *program_name = program_file_spec.GetFilename().AsCString();
     
             if (program_name)
             {
                 char program_init_file_name[PATH_MAX];
-                ::snprintf (program_init_file_name, sizeof(program_init_file_name), "%s-%s", init_file_path, program_name);
+                ::snprintf (program_init_file_name, sizeof(program_init_file_name), "%s-%s", init_file_path.c_str(), program_name);
                 init_file.SetFile (program_init_file_name, true);
                 if (!init_file.Exists())
                     init_file.Clear();
             }
         }
         
         if (!init_file && !m_skip_lldbinit_files)
-      init_file.SetFile (init_file_path, true);
+      init_file.SetFile (init_file_path.c_str(), false);
     }
 
     // If the file exists, tell HandleCommand to 'source' it; this will do the actual broadcasting
     // of the commands back to any appropriate listener (see CommandObjectSource::Execute for more details).
 
     if (init_file.Exists())
     {
         const bool saved_batch = SetBatchCommandMode (true);