This is an archive of the discontinued LLVM Phabricator instance.

Add support for intercepting thunks of the form `jmp dword ptr ds:[WWZZYYXX]`
ClosedPublic

Authored by ehsan on Jul 5 2014, 8:10 AM.

Details

Diff Detail

Event Timeline

ehsan updated this revision to Diff 11099.Jul 5 2014, 8:10 AM
ehsan retitled this revision from to Add support for intercepting thunks of the form `jmp dword ptr ds:[WWZZYYXX]`.
ehsan updated this object.
ehsan edited the test plan for this revision. (Show Details)
ehsan added a reviewer: timurrrr.
ehsan added a subscriber: Unknown Object (MLST).
timurrrr edited edge metadata.Jul 14 2014, 11:08 AM

LGTM
What function/CRT version does require this?

Do you have committer rights or should I commit on your behalf?

Sorry for the delay, I haven't seen the patch. Feel free to send ASan/Win
specific patches with me as a reviewer.
14 июля 2014 г. 21:52 пользователь "Ehsan Akhgari" <ehsan.akhgari@gmail.com>
написал:

ping?

http://reviews.llvm.org/D4397

IIRC some str* function in the MSVCRT dll... I do have commit access,
thanks for the review!

Ehsan
http://ehsanakhgari.org/

ehsan accepted this revision.Jul 14 2014, 1:37 PM
ehsan added a reviewer: ehsan.

Fixed in r212979.

This revision is now accepted and ready to land.Jul 14 2014, 1:37 PM
ehsan closed this revision.Jul 14 2014, 1:37 PM