[LNT] Error accessing URL /db_default/v4/nts/profile/ajax/getFunctions; NOT FOUND

[PrzemekWirkus]

Summary

Hi,
This patch is response to issue with LNT WebUI "Error accessing URL /db_default/v4/nts/profile/ajax/getFunctions; NOT FOUND". This issue appears in certain circumstances when user access Web UI under LNT / nts / profile.

Modified by this patch session query may fetch row(s) with profile_id values set to NULL. In order to fetch only not NULL values this patch modifies way we query DB. Query rows with profile_id set to NULL are not desired when query for LNT/nts/profile data.
Note that session query limits it's search to first element of the query which may have profile_id set to NULL (if entry of this type was imported to LNT database before any entry with profile data).

[PrzemekWirkus]

@leandron Would you be so kind and upstream this patch when code review is finished. I will go on holiday for whole March + I have no push permissions on this repo.
Cheers!

[MatzeB]

... looks like we should add some tests for the stuff in profile_views.py

[cmatthews]

I think it is the case that the if statement below is no longer needed?

[PrzemekWirkus]

@cmatthews Chris, I think below if is needed as session query still may may not return what we are expecting. E.g. in case of DB inconsistency.

[cmatthews]

@PrzemekWirkus okay

[jgreenhalgh]

Sorry, I should have caught this when we were reviewing this patch internally; this obviously leaves the lookups in:

v4_profile_ajax_getTopLevelCounters
v4_profile_ajax_getCodeForFunction
v4_profile_fwd2

Out of sync with the logic here. This has the expected consequence - we can now see the names of the hot functions, but can't do anything with them!

We should refactor the lookup out so this can't happen again.

[leandron]

Didn't manage to append to this code review, so I submitted https://reviews.llvm.org/D44389.

lnt/server/ui/profile_views.py

for x, y in age:
         z = int(float(x) / bucket_size)
         hist.setdefault(z, 0)
         hist[z] += y
     age = [[k * bucket_size, hist[k]] for k in sorted(hist.keys())]
 
     return render_template("profile_admin.html",
                            history=history, age=age, bucket_size=bucket_size)
 
-
-@v4_route("/profile/ajax/getFunctions")
-def v4_profile_ajax_getFunctions():
-    session = request.session
-    ts = request.get_testsuite()
-    runid = request.args.get('runid')
-    testid = request.args.get('testid')
-
-    profileDir = current_app.old_config.profileDir
-
-    idx = 0
-    tlc = {}
-    sample = session.query(ts.Sample) \
-                    .filter(ts.Sample.run_id == runid) \
-                    .filter(ts.Sample.test_id == testid).first()
+
+@v4_route("/profile/ajax/getFunctions")
+def v4_profile_ajax_getFunctions():
+    session = request.session
+    ts = request.get_testsuite()
+    runid = request.args.get('runid')
+    testid = request.args.get('testid')
+
+    profileDir = current_app.old_config.profileDir
+
+    idx = 0
+    tlc = {}
+    sample = session.query(ts.Sample) \
+                    .filter(ts.Sample.run_id == runid) \
+                    .filter(ts.Sample.test_id == testid) \
+                    .filter(ts.Sample.profile_id.isnot(None)).first()
     if sample and sample.profile:
         p = sample.profile.load(profileDir)
         return json.dumps([[n, f] for n, f in p.getFunctions().items()])
     else:
         abort(404)
 
 
 @v4_route("/profile/ajax/getTopLevelCounters")