This is an archive of the discontinued LLVM Phabricator instance.

[ELF] Print the .type assembly directive correctly for STT_NOTYPE
ClosedPublic

Authored by olista01 on Feb 9 2018, 3:32 AM.

Details

Summary

The llvm assembly parser and gas both accept "@notype" in the .type
assembly directive, but we were printing it as "@no_type", which isn't
accepted by either assembler.

Diff Detail

Repository
rL LLVM

Event Timeline

olista01 created this revision.Feb 9 2018, 3:32 AM
olista01 updated this revision to Diff 133585.Feb 9 2018, 3:35 AM

Add a triple to the test.

peter.smith accepted this revision.Feb 9 2018, 5:24 AM
peter.smith added a subscriber: peter.smith.

LGTM. I can confirm that gas uses notype and that the other .type values also match those in gas.

This revision is now accepted and ready to land.Feb 9 2018, 5:24 AM
This revision was automatically updated to reflect the committed changes.