This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.
ClosedPublic

Authored by STL_MSFT on Dec 7 2017, 4:09 PM.

Details

Summary

[libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.

I recently wrote a tool to audit MSVC's codebase for inconsistent line endings and unnecessary non-ASCII characters, and I ran it over libcxx's codebase too. I don't need any of these changes to be committed, so feel free to reject them - I just thought you might be interested.

There's a significant non-ASCII string in test/std/re/re.alg/re.alg.search/grep.pass.cpp which I haven't attempted to convert into escapes.

TODO.TXT
Avoid non-ASCII characters.

benchmarks/util_smartptr.bench.cpp
Change CRLF to LF.

test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_fr_FR.pass.cpp
Consistently comment "\u20ac" as EURO SIGN, its Unicode name, instead of the actual Unicode character.

test/std/utilities/allocator.adaptor/allocator.adaptor.members/construct_type.pass.cpp
Avoid non-ASCII dash.

Diff Detail

Event Timeline

STL_MSFT created this revision.Dec 7 2017, 4:09 PM
mclow.lists edited edge metadata.Dec 11 2017, 10:25 AM

Except for the stuff in TODO.txt these look good to me.
We need to do some work on that file - it's pretty out of date.

Would you like me to drop the changes to TODO.TXT?

LGTM as-is with the changes to the TODO file...

STL_MSFT accepted this revision.Dec 12 2017, 4:54 PM

Thanks, I've checked this in without the changes to TODO.TXT. Please let me know if you still want them, otherwise I consider this to be complete.

This revision is now accepted and ready to land.Dec 12 2017, 4:54 PM
STL_MSFT closed this revision.Dec 12 2017, 4:54 PM

Thanks, I've checked this in without the changes to TODO.TXT

Thanks - that works for me.