This is an archive of the discontinued LLVM Phabricator instance.

Differential D40930

Don't add a dependency on the backtrace library if it can't be found.
Needs ReviewPublic

Authored by vharron on Dec 6 2017, 4:29 PM.
This revision needs review, but all reviewers have resigned.

Details

Reviewers
labath
Summary

In compiling lldb-server for my system image, I ran into a case where backtrace can't be found but it's being added to the list of system libs anyway. This change prevents that and allows linking.

Diff Detail

Event Timeline

vharron created this revision.Dec 6 2017, 4:29 PM
Herald added a subscriber: mgorny. · View Herald TranscriptDec 6 2017, 4:29 PM
labath edited edge metadata.Dec 7 2017, 2:21 AM

The change makes sense, we just need to make the check cleaner.

source/Utility/CMakeLists.txt
25

Please use if (Backtrace_FOUND) here.

labath resigned from this revision.Nov 26 2018, 2:57 AM
labath added a subscriber: labath.

Revision Contents

PathSize
source/
Utility/
4 lines

Diff 125839

source/Utility/CMakeLists.txt

Context not available.
list(APPEND LLDB_SYSTEM_LIBS atomic) list(APPEND LLDB_SYSTEM_LIBS atomic)
endif() endif()
list(APPEND LLDB_SYSTEM_LIBS ${Backtrace_LIBRARY}) if (NOT "${Backtrace_LIBRARY}" STREQUAL "Backtrace_LIBRARY-NOTFOUND")
labathUnsubmitted
Not Done
ReplyInline Actions

Please use if (Backtrace_FOUND) here.

labath: Please use `if (Backtrace_FOUND)` here.
list(APPEND LLDB_SYSTEM_LIBS ${Backtrace_LIBRARY})
endif()
if (NOT LLDB_DISABLE_PYTHON AND NOT LLVM_BUILD_STATIC) if (NOT LLDB_DISABLE_PYTHON AND NOT LLVM_BUILD_STATIC)
list(APPEND LLDB_SYSTEM_LIBS ${PYTHON_LIBRARIES}) list(APPEND LLDB_SYSTEM_LIBS ${PYTHON_LIBRARIES})
Context not available.