Index: cfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp =================================================================== --- cfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp +++ cfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp @@ -3671,6 +3671,12 @@ // We already have an initializer in the class. return; + if (Var->hasAttr() && + !(OldVar->getInit() && OldVar->checkInitIsICE())) { + // Do not dynamically initialize dllimport variables. + return; + } + if (OldVar->getInit()) { if (Var->isStaticDataMember() && !OldVar->isOutOfLine()) PushExpressionEvaluationContext(Sema::ConstantEvaluated, OldVar); Index: cfe/trunk/test/CodeGenCXX/dllimport.cpp =================================================================== --- cfe/trunk/test/CodeGenCXX/dllimport.cpp +++ cfe/trunk/test/CodeGenCXX/dllimport.cpp @@ -5,6 +5,10 @@ // RUN: %clang_cc1 -triple i686-windows-msvc -fno-rtti -emit-llvm -std=c++1y -O1 -o - %s -DMSABI | FileCheck --check-prefix=MO1 %s // RUN: %clang_cc1 -triple i686-windows-gnu -fno-rtti -emit-llvm -std=c++1y -O1 -o - %s | FileCheck --check-prefix=GO1 %s +// CHECK-NOT doesn't play nice with CHECK-DAG, so use separate run lines. +// RUN: %clang_cc1 -triple i686-windows-msvc -fno-rtti -emit-llvm -std=c++1y -O0 -o - %s -DMSABI | FileCheck --check-prefix=MSC2 %s +// RUN: %clang_cc1 -triple i686-windows-gnu -fno-rtti -emit-llvm -std=c++1y -O0 -o - %s | FileCheck --check-prefix=GNU2 %s + // Helper structs to make templates more expressive. struct ImplicitInst_Imported {}; struct ImplicitInst_NotImported {}; @@ -219,6 +223,11 @@ __declspec(dllimport) __attribute__((noinline)) inline void noinline() {} USE(noinline) +// MSC2-NOT: @"\01?alwaysInline@@YAXXZ"() +// GNU2-NOT: @_Z12alwaysInlinev() +__declspec(dllimport) __attribute__((always_inline)) inline void alwaysInline() {} +USE(alwaysInline) + // Redeclarations // MSC-DAG: declare dllimport void @"\01?redecl1@@YAXXZ"() // GNU-DAG: declare dllimport void @_Z7redecl1v() @@ -580,13 +589,26 @@ int f() { return S::x; } } -//===----------------------------------------------------------------------===// -// Negative checks -//===----------------------------------------------------------------------===// - -// These checks are at the end to avoid interference with the DAG checks. - -// MSC-NOT: @"\01?alwaysInline@@YAXXZ"() -// GNU-NOT: @_Z12alwaysInlinev() -__declspec(dllimport) __attribute__((always_inline)) inline void alwaysInline() {} -USE(alwaysInline) +namespace PR19933 { +// Don't dynamically initialize dllimport vars. +// MSC2-NOT: @llvm.global_ctors +// GNU2-NOT: @llvm.global_ctors + + struct NonPOD { NonPOD(); }; + template struct A { static NonPOD x; }; + template NonPOD A::x; + template struct __declspec(dllimport) A; + // MSC-DAG: @"\01?x@?$A@H@PR19933@@2UNonPOD@2@A" = available_externally dllimport global %"struct.PR19933::NonPOD" zeroinitializer + + int f(); + template struct B { static int x; }; + template int B::x = f(); + template struct __declspec(dllimport) B; + // MSC-DAG: @"\01?x@?$B@H@PR19933@@2HA" = available_externally dllimport global i32 0 + + constexpr int g() { return 42; } + template struct C { static int x; }; + template int C::x = g(); + template struct __declspec(dllimport) C; + // MSC-DAG: @"\01?x@?$C@H@PR19933@@2HA" = available_externally dllimport global i32 42 +}