This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Restore __builtin_wasm_rethrow builtin
ClosedPublic

Authored by aheejin on Sep 15 2017, 4:22 PM.

Details

Summary

Restore the __builtin_wasm_rethrow builtin deleted in D37931. On second
thought, it appears it can be used to implement __cxa_rethrow.

Event Timeline

aheejin created this revision.Sep 15 2017, 4:22 PM
dschuff accepted this revision.Sep 15 2017, 4:53 PM
This revision is now accepted and ready to land.Sep 15 2017, 4:53 PM

Or you could just call it a revert of the previous patch, if you wanted.

aheejin closed this revision.Sep 15 2017, 6:09 PM

(btw if there's a link in the commit message to the review, it should close automatically after commit)

I didn't close it explicitly. I just committed the change. I don't know why my CLs do not say "closed by commit rxxxx" like other CLs...