This is an archive of the discontinued LLVM Phabricator instance.

Differential D35511

Add element-atomic mem intrinsic canary tests for Thread Sanitizer.
AbandonedPublic

Authored by dneilson on Jul 17 2017, 2:33 PM.

Details

Reviewers
reames
Summary

Add canary tests to verify that TSAN currently does not lower the element atomic memory intrinsics for memcpy, memmove, and memset.

Placeholder tests that will fail once element atomic @llvm.mem[cpy|move|set] instrinsics have been added to the MemIntrinsic class hierarchy. These will act as a reminder to verify that MSAN handles these intrinsics properly once they have been added to that class hierarchy.

Diff Detail

Event Timeline

dneilson created this revision.Jul 17 2017, 2:33 PM
dneilson added a comment.Aug 17 2017, 10:54 AM

ping

reames accepted this revision.Aug 25 2017, 3:40 PM
This revision is now accepted and ready to land.Aug 25 2017, 3:40 PM
dneilson abandoned this revision.May 29 2018, 2:13 PM

Revision Contents

PathSize
test/
Instrumentation/
ThreadSanitizer/
45 lines

Diff 106957

test/Instrumentation/ThreadSanitizer/tsan_basic.ll

Show First 20 Lines • Show All 48 Lines • ▼ Show 20 Lines
entry: entry:
tail call void @llvm.memset.p0i8.i64(i8* %x, i8 77, i64 16, i32 4, i1 false) tail call void @llvm.memset.p0i8.i64(i8* %x, i8 77, i64 16, i32 4, i1 false)
ret void ret void
; CHECK: define void @MemSetTest ; CHECK: define void @MemSetTest
; CHECK: call i8* @memset ; CHECK: call i8* @memset
; CHECK: ret void ; CHECK: ret void
} }
; -----------
; Canary tests for element atomic memory intrinsics. Make sure that tsan does not lower
; the instrinsic to a function call.
declare void @llvm.memcpy.element.unordered.atomic.p0i8.p0i8.i64(i8* nocapture writeonly, i8* nocapture readonly, i64, i32) nounwind
declare void @llvm.memmove.element.unordered.atomic.p0i8.p0i8.i64(i8* nocapture writeonly, i8* nocapture readonly, i64, i32) nounwind
declare void @llvm.memset.element.unordered.atomic.p0i8.i64(i8* nocapture writeonly, i8, i64, i32)
define void @elementAtomic_memCpyTest(i8* nocapture %x, i8* nocapture %y) {
; CHECK-LABEL: elementAtomic_memCpyTest
; CHECK-NEXT: [[V:%[0-9]+]] = call i8* @llvm.returnaddress(i32 0)
; CHECK-NEXT: call void @__tsan_func_entry(i8* [[V]])
; CHECK-NEXT: tail call void @llvm.memcpy.element.unordered.atomic.p0i8.p0i8.i64(i8* align 1 %x, i8* align 1 %y, i64 16, i32 1)
; CHECK-NEXT: call void @__tsan_func_exit()
; CHECK-NEXT: ret void
tail call void @llvm.memcpy.element.unordered.atomic.p0i8.p0i8.i64(i8* align 1 %x, i8* align 1 %y, i64 16, i32 1)
ret void
}
define void @elementAtomic_memMoveTest(i8* nocapture %x, i8* nocapture %y) {
; CHECK-LABEL: elementAtomic_memMoveTest
; CHECK-NEXT: [[V:%[0-9]+]] = call i8* @llvm.returnaddress(i32 0)
; CHECK-NEXT: call void @__tsan_func_entry(i8* [[V]])
; CHECK-NEXT: tail call void @llvm.memmove.element.unordered.atomic.p0i8.p0i8.i64(i8* align 1 %x, i8* align 1 %y, i64 16, i32 1)
; CHECK-NEXT: call void @__tsan_func_exit()
; CHECK-NEXT: ret void
tail call void @llvm.memmove.element.unordered.atomic.p0i8.p0i8.i64(i8* align 1 %x, i8* align 1 %y, i64 16, i32 1)
ret void
}
define void @elementAtomic_memSetTest(i8* nocapture %x) {
; CHECK-LABEL: elementAtomic_memSetTest
; CHECK-NEXT: [[V:%[0-9]+]] = call i8* @llvm.returnaddress(i32 0)
; CHECK-NEXT: call void @__tsan_func_entry(i8* [[V]])
; CHECK-NEXT: tail call void @llvm.memset.element.unordered.atomic.p0i8.i64(i8* align 1 %x, i8 86, i64 16, i32 1)
; CHECK-NEXT: call void @__tsan_func_exit()
; CHECK-NEXT: ret void
tail call void @llvm.memset.element.unordered.atomic.p0i8.i64(i8* align 1 %x, i8 86, i64 16, i32 1)
ret void
}
; -----------
; CHECK-LABEL: @SwiftError ; CHECK-LABEL: @SwiftError
; CHECK-NOT: __tsan_read ; CHECK-NOT: __tsan_read
; CHECK-NOT: __tsan_write ; CHECK-NOT: __tsan_write
; CHECK: ret ; CHECK: ret
define void @SwiftError(i8** swifterror) sanitize_thread { define void @SwiftError(i8** swifterror) sanitize_thread {
%swifterror_ptr_value = load i8*, i8** %0 %swifterror_ptr_value = load i8*, i8** %0
store i8* null, i8** %0 store i8* null, i8** %0
%swifterror_addr = alloca swifterror i8* %swifterror_addr = alloca swifterror i8*
Show All 18 Lines