This is an archive of the discontinued LLVM Phabricator instance.

Add an X86 AVX2 clang builder and slave
ClosedPublic

Authored by eladcohen on Jul 10 2017, 6:13 AM.

Details

Summary

Add initial builder and slave configurations for an X86-64 AVX2 Linux buildbot

Diff Detail

Event Timeline

eladcohen created this revision.Jul 10 2017, 6:13 AM
zvi added inline comments.Jul 10 2017, 8:07 AM
buildbot/osuosl/master/config/builders.py
634 ↗(On Diff #105844)

does the 'clang' component in the machine name mean:

  • We are using Clang to build LLVM and Clanf

or:

  • We are building LLVM + Clang using the Ubuntu default system compiler?
638 ↗(On Diff #105844)

Given that we are allowing lots of jobs to run in parallel, should we be using Ninja instead of Make? It's known to scale better.

1121 ↗(On Diff #105844)

Looks like this line + 2 below are only white-space changes.

eladcohen added inline comments.Jul 10 2017, 8:19 AM
buildbot/osuosl/master/config/builders.py
634 ↗(On Diff #105844)

We are building LLVM + Clang using the Ubuntu default system compiler.

Following the convention of all the other buildbots, the 'clang' component stands for building LLVM+Clang (Using the ClangCMakeBuildFactory) as opposed to the 'llvm' bots which build llvm without clang.

638 ↗(On Diff #105844)

Judging by the other buildbots that use ClangCmakeBuildFactory - It defaults to Ninja

1121 ↗(On Diff #105844)

Yes, I'm not sure why my editor added these. I'll remove them.

gkistanova accepted this revision.Jul 10 2017, 11:17 PM

LGTM, assuming you will remove the unrelated cosmetic changes, and figure out what place you want to specify the number of jobs. Up to me, a slave property seems a better and more natural place.

buildbot/osuosl/master/config/builders.py
638 ↗(On Diff #105844)

No need to specify a number of jobs here if you did it as the slave property.

This revision is now accepted and ready to land.Jul 10 2017, 11:17 PM
eladcohen marked an inline comment as done.
  • Removed the duplicate number of jobs specification.
  • Removed the unrelated whitespace changes.
zvi accepted this revision.Jul 10 2017, 11:40 PM

Thanks for the review.
Committed in r307753.

eladcohen closed this revision.Jul 12 2017, 10:08 PM

Committed in r307753.