Index: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp =================================================================== --- lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp +++ lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp @@ -559,6 +559,108 @@ if (const llvm::APSInt *RHSValue = getKnownValue(state, rhs)) return MakeSymIntVal(Sym, op, *RHSValue, resultTy); + // If comparing two symbolic expressions of the format S, S+n or S-n + // rearrange the comparison by moving symbols to the left side and the + // concrete integer to the right. This enables the range based constraint + // manager to handle these comparisons. + if (BinaryOperator::isComparisonOp(op) && + rhs.getSubKind() == nonloc::SymbolValKind) { + SymbolRef rSym = rhs.castAs().getSymbol(); + if (Sym->getType()->isIntegerType() && + rSym->getType()->isIntegerType()) { + const llvm::APSInt *lInt = nullptr, *rInt = nullptr; + BinaryOperator::Opcode lop, rop; + + // Type of n in S+n or S-n is the same as the type of S+n or S-n. + // Since they are equal on both sides, no need to convert them. + if (const SymIntExpr *lSymIntExpr = dyn_cast(Sym)) { + lop = lSymIntExpr->getOpcode(); + if (BinaryOperator::isAdditiveOp(lop)) { + lInt = &lSymIntExpr->getRHS(); + Sym = lSymIntExpr->getLHS(); + } + } + if (const SymIntExpr *rSymIntExpr = dyn_cast(rSym)) { + rop = rSymIntExpr->getOpcode(); + if (BinaryOperator::isAdditiveOp(rop)) { + rInt = &rSymIntExpr->getRHS(); + rSym = rSymIntExpr->getLHS(); + } + } + + auto origWidth = + std::max(BasicVals.getAPSIntType(Sym->getType()).getBitWidth(), + BasicVals.getAPSIntType(rSym->getType()).getBitWidth()); + + if (origWidth < 128) { + auto newWidth = std::max(2 * origWidth, (uint32_t) 8); + auto newAPSIntType = APSIntType(newWidth, false); + bool reverse; // Avoid negative numbers in case of unsigned types + const llvm::APSInt *newRhs; + if (lInt && rInt) { + auto lIntExt = (Sym != rSym) ? newAPSIntType.convert(*lInt) : + (*lInt); + auto rIntExt = (Sym != rSym) ? newAPSIntType.convert(*rInt) : + (*rInt); + if (lop != rop) { + newRhs = &BasicVals.getValue(lIntExt + rIntExt); + reverse = (lop == BO_Add); + } else { + if (*lInt >= *rInt) { + newRhs = &BasicVals.getValue(lIntExt - rIntExt); + reverse = (lop == BO_Add); + } else { + newRhs = &BasicVals.getValue(rIntExt - lIntExt); + reverse = (lop == BO_Sub); + } + } + } else if (lInt) { + auto lIntExt = (Sym != rSym) ? newAPSIntType.convert(*lInt) : + (*lInt); + newRhs = &BasicVals.getValue(lIntExt); + reverse = (lop == BO_Add); + } else if (rInt) { + auto rIntExt = (Sym != rSym) ? newAPSIntType.convert(*rInt) : + (*rInt); + newRhs = &BasicVals.getValue(rIntExt); + reverse = (rop == BO_Sub); + } else { + newRhs = &BasicVals.getValue(llvm::APSInt(newWidth, false)); + reverse = false; + } + + if (*newRhs < 0) { + newRhs = &BasicVals.getValue(-*newRhs); + reverse = !reverse; + } + + if (reverse) { + op = BinaryOperator::reverseComparisonOp(op); + } + + if (Sym == rSym) { + return nonloc::ConcreteInt(*BasicVals.evalAPSInt( + op, APSIntType(*newRhs).getZeroValue(), *newRhs)); + } + + auto &AC = state->getStateManager().getContext(); + auto newType = AC.getIntTypeForBitwidth(newWidth, true); + + const SymExpr *castedSym = SymMgr.getCastSymbol(Sym, Sym->getType(), + newType); + const SymExpr *castedRSym = SymMgr.getCastSymbol(rSym, + rSym->getType(), + newType); + + const SymExpr *newLhs = + reverse + ? SymMgr.getSymSymExpr(castedRSym, BO_Sub, castedSym, newType) + : SymMgr.getSymSymExpr(castedSym, BO_Sub, castedRSym, newType); + return makeNonLoc(newLhs, op, *newRhs, resultTy); + } + } + } + // Give up -- this is not a symbolic expression we can handle. return makeSymExprValNN(state, op, InputLHS, InputRHS, resultTy); } Index: test/Analysis/std-c-library-functions.c =================================================================== --- test/Analysis/std-c-library-functions.c +++ test/Analysis/std-c-library-functions.c @@ -57,8 +57,7 @@ size_t y = fread(buf, sizeof(int), 10, fp); clang_analyzer_eval(y <= 10); // expected-warning{{TRUE}} size_t z = fwrite(buf, sizeof(int), y, fp); - // FIXME: should be TRUE once symbol-symbol constraint support is improved. - clang_analyzer_eval(z <= y); // expected-warning{{UNKNOWN}} + clang_analyzer_eval(z <= y); // expected-warning{{TRUE}} } ssize_t getline(char **, size_t *, FILE *); Index: test/Analysis/svalbuilder-rearrange-comparisons.c =================================================================== --- /dev/null +++ test/Analysis/svalbuilder-rearrange-comparisons.c @@ -0,0 +1,913 @@ +// RUN: %clang_analyze_cc1 -analyzer-checker=debug.ExprInspection -verify %s + +void clang_analyzer_dump(int x); +void clang_analyzer_eval(int x); +void clang_analyzer_printState(); + +int f(); + +void compare_different_symbol_equal() { + int x = f(), y = f(); + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{conj_$5{int}}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) == 0}} +} + +void compare_different_symbol_plus_left_int_equal() { + int x = f()+1, y = f(); + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(y); // expected-warning{{conj_$5{int}}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{(((long) (conj_$5{int})) - ((long) (conj_$2{int}))) == 1}} +} + +void compare_different_symbol_minus_left_int_equal() { + int x = f()-1, y = f(); + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(y); // expected-warning{{conj_$5{int}}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) == 1}} +} + +void compare_different_symbol_plus_right_int_equal() { + int x = f(), y = f()+2; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) + 2}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) == 2}} +} + +void compare_different_symbol_minus_right_int_equal() { + int x = f(), y = f()-2; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) - 2}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{(((long) (conj_$5{int})) - ((long) (conj_$2{int}))) == 2}} +} + +void compare_different_symbol_plus_left_plus_right_int_equal() { + int x = f()+2, y = f()+1; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 2}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) + 1}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{(((long) (conj_$5{int})) - ((long) (conj_$2{int}))) == 1}} +} + +void compare_different_symbol_plus_left_minus_right_int_equal() { + int x = f()+2, y = f()-1; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 2}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) - 1}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{(((long) (conj_$5{int})) - ((long) (conj_$2{int}))) == 3}} +} + +void compare_different_symbol_minus_left_plus_right_int_equal() { + int x = f()-2, y = f()+1; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 2}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) + 1}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) == 3}} +} + +void compare_different_symbol_minus_left_minus_right_int_equal() { + int x = f()-2, y = f()-1; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 2}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) - 1}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) == 1}} +} + +void compare_same_symbol_equal() { + int x = f(), y = x; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{1 S32b}} +} + +void compare_same_symbol_plus_left_int_equal() { + int x = f(), y = x; + ++x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(y); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_minus_left_int_equal() { + int x = f(), y = x; + --x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(y); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_plus_right_int_equal() { + int x = f(), y = x+1; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_minus_right_int_equal() { + int x = f(), y = x-1; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_plus_left_plus_right_int_equal() { + int x = f(), y = x+1; + ++x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{1 S32b}} +} + +void compare_same_symbol_plus_left_minus_right_int_equal() { + int x = f(), y = x-1; + ++x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_minus_left_plus_right_int_equal() { + int x = f(), y = x+1; + --x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_minus_left_minus_right_int_equal() { + int x = f(), y = x-1; + --x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{1 S32b}} +} + +void compare_different_symbol_less_or_equal() { + int x = f(), y = f(); + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{conj_$5{int}}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) <= 0}} +} + +void compare_different_symbol_plus_left_int_less_or_equal() { + int x = f()+1, y = f(); + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(y); // expected-warning{{conj_$5{int}}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{(((long) (conj_$5{int})) - ((long) (conj_$2{int}))) >= 1}} +} + +void compare_different_symbol_minus_left_int_less_or_equal() { + int x = f()-1, y = f(); + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(y); // expected-warning{{conj_$5{int}}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) <= 1}} +} + +void compare_different_symbol_plus_right_int_less_or_equal() { + int x = f(), y = f()+2; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) + 2}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) <= 2}} +} + +void compare_different_symbol_minus_right_int_less_or_equal() { + int x = f(), y = f()-2; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) - 2}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{(((long) (conj_$5{int})) - ((long) (conj_$2{int}))) >= 2}} +} + +void compare_different_symbol_plus_left_plus_right_int_less_or_equal() { + int x = f()+2, y = f()+1; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 2}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) + 1}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{(((long) (conj_$5{int})) - ((long) (conj_$2{int}))) >= 1}} +} + +void compare_different_symbol_plus_left_minus_right_int_less_or_equal() { + int x = f()+2, y = f()-1; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 2}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) - 1}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{(((long) (conj_$5{int})) - ((long) (conj_$2{int}))) >= 3}} +} + +void compare_different_symbol_minus_left_plus_right_int_less_or_equal() { + int x = f()-2, y = f()+1; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 2}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) + 1}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) <= 3}} +} + +void compare_different_symbol_minus_left_minus_right_int_less_or_equal() { + int x = f()-2, y = f()-1; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 2}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) - 1}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) <= 1}} +} + +void compare_same_symbol_less_or_equal() { + int x = f(), y = x; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{1 S32b}} +} + +void compare_same_symbol_plus_left_int_less_or_equal() { + int x = f(), y = x; + ++x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(y); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_minus_left_int_less_or_equal() { + int x = f(), y = x; + --x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(y); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{1 S32b}} +} + +void compare_same_symbol_plus_right_int_less_or_equal() { + int x = f(), y = x+1; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{1 S32b}} +} + +void compare_same_symbol_minus_right_int_less_or_equal() { + int x = f(), y = x-1; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_plus_left_plus_right_int_less_or_equal() { + int x = f(), y = x+1; + ++x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{1 S32b}} +} + +void compare_same_symbol_plus_left_minus_right_int_less_or_equal() { + int x = f(), y = x-1; + ++x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_minus_left_plus_right_int_less_or_equal() { + int x = f(), y = x+1; + --x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{1 S32b}} +} + +void compare_same_symbol_minus_left_minus_right_int_less_or_equal() { + int x = f(), y = x-1; + --x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{1 S32b}} +} + +void compare_different_symbol_less() { + int x = f(), y = f(); + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{conj_$5{int}}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) < 0}} +} + +void compare_different_symbol_plus_left_int_less() { + int x = f()+1, y = f(); + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(y); // expected-warning{{conj_$5{int}}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{(((long) (conj_$5{int})) - ((long) (conj_$2{int}))) > 1}} +} + +void compare_different_symbol_minus_left_int_less() { + int x = f()-1, y = f(); + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(y); // expected-warning{{conj_$5{int}}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) < 1}} +} + +void compare_different_symbol_plus_right_int_less() { + int x = f(), y = f()+2; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) + 2}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) < 2}} +} + +void compare_different_symbol_minus_right_int_less() { + int x = f(), y = f()-2; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) - 2}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{(((long) (conj_$5{int})) - ((long) (conj_$2{int}))) > 2}} +} + +void compare_different_symbol_plus_left_plus_right_int_less() { + int x = f()+2, y = f()+1; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 2}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) + 1}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{(((long) (conj_$5{int})) - ((long) (conj_$2{int}))) > 1}} +} + +void compare_different_symbol_plus_left_minus_right_int_less() { + int x = f()+2, y = f()-1; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 2}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) - 1}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{(((long) (conj_$5{int})) - ((long) (conj_$2{int}))) > 3}} +} + +void compare_different_symbol_minus_left_plus_right_int_less() { + int x = f()-2, y = f()+1; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 2}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) + 1}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) < 3}} +} + +void compare_different_symbol_minus_left_minus_right_int_less() { + int x = f()-2, y = f()-1; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 2}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) - 1}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) < 1}} +} + +void compare_same_symbol_less() { + int x = f(), y = x; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_plus_left_int_less() { + int x = f(), y = x; + ++x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(y); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_minus_left_int_less() { + int x = f(), y = x; + --x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(y); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{1 S32b}} +} + +void compare_same_symbol_plus_right_int_less() { + int x = f(), y = x+1; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{1 S32b}} +} + +void compare_same_symbol_minus_right_int_less() { + int x = f(), y = x-1; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_plus_left_plus_right_int_less() { + int x = f(), y = x+1; + ++x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_plus_left_minus_right_int_less() { + int x = f(), y = x-1; + ++x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_minus_left_plus_right_int_less() { + int x = f(), y = x+1; + --x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{1 S32b}} +} + +void compare_same_symbol_minus_left_minus_right_int_less() { + int x = f(), y = x-1; + --x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{0 S32b}} +} + +void compare_different_symbol_equal_unsigned() { + unsigned x = f(), y = f(); + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{conj_$5{int}}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) == 0}} +} + +void compare_different_symbol_plus_left_int_equal_unsigned() { + unsigned x = f()+1, y = f(); + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(y); // expected-warning{{conj_$5{int}}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{(((long) (conj_$5{int})) - ((long) (conj_$2{int}))) == 1}} +} + +void compare_different_symbol_minus_left_int_equal_unsigned() { + unsigned x = f()-1, y = f(); + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(y); // expected-warning{{conj_$5{int}}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) == 1}} +} + +void compare_different_symbol_plus_right_int_equal_unsigned() { + unsigned x = f(), y = f()+2; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) + 2}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) == 2}} +} + +void compare_different_symbol_minus_right_int_equal_unsigned() { + unsigned x = f(), y = f()-2; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) - 2}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{(((long) (conj_$5{int})) - ((long) (conj_$2{int}))) == 2}} +} + +void compare_different_symbol_plus_left_plus_right_int_equal_unsigned() { + unsigned x = f()+2, y = f()+1; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 2}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) + 1}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{(((long) (conj_$5{int})) - ((long) (conj_$2{int}))) == 1}} +} + +void compare_different_symbol_plus_left_minus_right_int_equal_unsigned() { + unsigned x = f()+2, y = f()-1; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 2}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) - 1}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{(((long) (conj_$5{int})) - ((long) (conj_$2{int}))) == 3}} +} + +void compare_different_symbol_minus_left_plus_right_int_equal_unsigned() { + unsigned x = f()-2, y = f()+1; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 2}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) + 1}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) == 3}} +} + +void compare_different_symbol_minus_left_minus_right_int_equal_unsigned() { + unsigned x = f()-2, y = f()-1; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 2}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) - 1}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) == 1}} +} + +void compare_same_symbol_equal_unsigned() { + unsigned x = f(), y = x; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{1 S32b}} +} + +void compare_same_symbol_plus_left_int_equal_unsigned() { + unsigned x = f(), y = x; + ++x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(y); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_minus_left_int_equal_unsigned() { + unsigned x = f(), y = x; + --x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(y); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_plus_right_int_equal_unsigned() { + unsigned x = f(), y = x+1; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_minus_right_int_equal_unsigned() { + unsigned x = f(), y = x-1; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_plus_left_plus_right_int_equal_unsigned() { + unsigned x = f(), y = x+1; + ++x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{1 S32b}} +} + +void compare_same_symbol_plus_left_minus_right_int_equal_unsigned() { + unsigned x = f(), y = x-1; + ++x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_minus_left_plus_right_int_equal_unsigned() { + unsigned x = f(), y = x+1; + --x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_minus_left_minus_right_int_equal_unsigned() { + unsigned x = f(), y = x-1; + --x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(x == y); + // expected-warning@-1{{1 S32b}} +} + +void compare_different_symbol_less_or_equal_unsigned() { + unsigned x = f(), y = f(); + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{conj_$5{int}}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) <= 0}} +} + +void compare_different_symbol_plus_left_int_less_or_equal_unsigned() { + unsigned x = f()+1, y = f(); + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(y); // expected-warning{{conj_$5{int}}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{(((long) (conj_$5{int})) - ((long) (conj_$2{int}))) >= 1}} +} + +void compare_different_symbol_minus_left_int_less_or_equal_unsigned() { + unsigned x = f()-1, y = f(); + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(y); // expected-warning{{conj_$5{int}}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) <= 1}} +} + +void compare_different_symbol_plus_right_int_less_or_equal_unsigned() { + unsigned x = f(), y = f()+2; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) + 2}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) <= 2}} +} + +void compare_different_symbol_minus_right_int_less_or_equal_unsigned() { + unsigned x = f(), y = f()-2; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) - 2}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{(((long) (conj_$5{int})) - ((long) (conj_$2{int}))) >= 2}} +} + +void compare_different_symbol_plus_left_plus_right_int_less_or_equal_unsigned() { + unsigned x = f()+2, y = f()+1; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 2}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) + 1}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{(((long) (conj_$5{int})) - ((long) (conj_$2{int}))) >= 1}} +} + +void compare_different_symbol_plus_left_minus_right_int_less_or_equal_unsigned() { + unsigned x = f()+2, y = f()-1; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 2}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) - 1}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{(((long) (conj_$5{int})) - ((long) (conj_$2{int}))) >= 3}} +} + +void compare_different_symbol_minus_left_plus_right_int_less_or_equal_unsigned() { + unsigned x = f()-2, y = f()+1; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 2}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) + 1}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) <= 3}} +} + +void compare_different_symbol_minus_left_minus_right_int_less_or_equal_unsigned() { + unsigned x = f()-2, y = f()-1; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 2}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) - 1}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) <= 1}} +} + +void compare_same_symbol_less_or_equal_unsigned() { + unsigned x = f(), y = x; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{1 S32b}} +} + +void compare_same_symbol_plus_left_int_less_or_equal_unsigned() { + unsigned x = f(), y = x; + ++x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(y); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_minus_left_int_less_or_equal_unsigned() { + unsigned x = f(), y = x; + --x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(y); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{1 S32b}} +} + +void compare_same_symbol_plus_right_int_less_or_equal_unsigned() { + unsigned x = f(), y = x+1; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{1 S32b}} +} + +void compare_same_symbol_minus_right_int_less_or_equal_unsigned() { + unsigned x = f(), y = x-1; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_plus_left_plus_right_int_less_or_equal_unsigned() { + unsigned x = f(), y = x+1; + ++x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{1 S32b}} +} + +void compare_same_symbol_plus_left_minus_right_int_less_or_equal_unsigned() { + unsigned x = f(), y = x-1; + ++x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_minus_left_plus_right_int_less_or_equal_unsigned() { + unsigned x = f(), y = x+1; + --x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{1 S32b}} +} + +void compare_same_symbol_minus_left_minus_right_int_less_or_equal_unsigned() { + unsigned x = f(), y = x-1; + --x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(x <= y); + // expected-warning@-1{{1 S32b}} +} + +void compare_different_symbol_less_unsigned() { + unsigned x = f(), y = f(); + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{conj_$5{int}}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) < 0}} +} + +void compare_different_symbol_plus_left_int_less_unsigned() { + unsigned x = f()+1, y = f(); + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(y); // expected-warning{{conj_$5{int}}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{(((long) (conj_$5{int})) - ((long) (conj_$2{int}))) > 1}} +} + +void compare_different_symbol_minus_left_int_less_unsigned() { + unsigned x = f()-1, y = f(); + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(y); // expected-warning{{conj_$5{int}}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) < 1}} +} + +void compare_different_symbol_plus_right_int_less_unsigned() { + unsigned x = f(), y = f()+2; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) + 2}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) < 2}} +} + +void compare_different_symbol_minus_right_int_less_unsigned() { + unsigned x = f(), y = f()-2; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) - 2}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{(((long) (conj_$5{int})) - ((long) (conj_$2{int}))) > 2}} +} + +void compare_different_symbol_plus_left_plus_right_int_less_unsigned() { + unsigned x = f()+2, y = f()+1; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 2}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) + 1}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{(((long) (conj_$5{int})) - ((long) (conj_$2{int}))) > 1}} +} + +void compare_different_symbol_plus_left_minus_right_int_less_unsigned() { + unsigned x = f()+2, y = f()-1; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 2}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) - 1}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{(((long) (conj_$5{int})) - ((long) (conj_$2{int}))) > 3}} +} + +void compare_different_symbol_minus_left_plus_right_int_less_unsigned() { + unsigned x = f()-2, y = f()+1; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 2}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) + 1}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) < 3}} +} + +void compare_different_symbol_minus_left_minus_right_int_less_unsigned() { + unsigned x = f()-2, y = f()-1; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 2}} + clang_analyzer_dump(y); // expected-warning{{(conj_$5{int}) - 1}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{(((long) (conj_$2{int})) - ((long) (conj_$5{int}))) < 1}} +} + +void compare_same_symbol_less_unsigned() { + unsigned x = f(), y = x; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_plus_left_int_less_unsigned() { + unsigned x = f(), y = x; + ++x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(y); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_minus_left_int_less_unsigned() { + unsigned x = f(), y = x; + --x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(y); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{1 S32b}} +} + +void compare_same_symbol_plus_right_int_less_unsigned() { + unsigned x = f(), y = x+1; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{1 S32b}} +} + +void compare_same_symbol_minus_right_int_less_unsigned() { + unsigned x = f(), y = x-1; + clang_analyzer_dump(x); // expected-warning{{conj_$2{int}}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_plus_left_plus_right_int_less_unsigned() { + unsigned x = f(), y = x+1; + ++x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_plus_left_minus_right_int_less_unsigned() { + unsigned x = f(), y = x-1; + ++x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{0 S32b}} +} + +void compare_same_symbol_minus_left_plus_right_int_less_unsigned() { + unsigned x = f(), y = x+1; + --x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) + 1}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{1 S32b}} +} + +void compare_same_symbol_minus_left_minus_right_int_less_unsigned() { + unsigned x = f(), y = x-1; + --x; + clang_analyzer_dump(x); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(y); // expected-warning{{(conj_$2{int}) - 1}} + clang_analyzer_dump(x < y); + // expected-warning@-1{{0 S32b}} +} + +void overflow(signed char n, signed char m) { + if (n + 0 > m + 0) { + clang_analyzer_eval(n - 126 == m + 3); // expected-warning{{UNKNOWN}} + } +}