This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Cleanup WasmObjectWriter.cpp. NFC
ClosedPublic

Authored by sbc100 on Jun 21 2017, 2:25 PM.

Details

Summary
  • Use auto where appropriate
  • Use early continue to reduce nesting
  • Remove stray comment line
  • Use C++ foreach over explicit iterator

Diff Detail

Repository
rL LLVM

Event Timeline

sbc100 created this revision.Jun 21 2017, 2:25 PM
sbc100 edited the summary of this revision. (Show Details)Jun 21 2017, 2:27 PM
sbc100 added a reviewer: jgravelle-google.
jgravelle-google accepted this revision.Jun 21 2017, 4:34 PM

Lots of nice changes

This revision is now accepted and ready to land.Jun 21 2017, 4:34 PM
sbc100 retitled this revision from [WebAssemly] Cleanup WasmObjectWriter.cpp. NFC to [WebAssembly] Cleanup WasmObjectWriter.cpp. NFC.Jun 21 2017, 4:45 PM
sbc100 edited the summary of this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.