This is an archive of the discontinued LLVM Phabricator instance.

CodeGen : Check LLVM_ENABLE_DUMP definition for dumpMachineInstrRangeWithSlotIndex.
ClosedPublic

Authored by flyingforyou on Feb 24 2017, 6:13 PM.

Details

Summary

Add missing check routine for dumpMachineInstrRangeWithSlotIndex including LLVM_DUMP_METHOD.

Diff Detail

Repository
rL LLVM

Event Timeline

flyingforyou created this revision.Feb 24 2017, 6:13 PM
bkramer edited edge metadata.Mar 1 2017, 7:39 AM

This will get you an unused function warning if NDEBUG && LLVM_ENABLE_DUMP. You can use LLVM_DUMP_METHOD to avoid that.

flyingforyou edited the summary of this revision. (Show Details)

Addressing Benjamin's comment.
Thanks.

bkramer accepted this revision.Mar 27 2017, 1:38 AM

This is fine.

This revision is now accepted and ready to land.Mar 27 2017, 1:38 AM
This revision was automatically updated to reflect the committed changes.

Thanks Benjamin.
Committed in r298895.