Page MenuHomePhabricator

Properly register the ARMConstantIslands pass with PassRegistry
AbandonedPublic

Authored by rmaprath on Feb 9 2017, 7:27 AM.

Details

Summary

This pass is currently not registered properly with the PassRegistry, making
it invisible for llc options like -stop-after and -run-pass.

I need this pass to be available for those options for a follow-up patch.

Diff Detail

Event Timeline

rmaprath created this revision.Feb 9 2017, 7:27 AM
john.brawn added inline comments.Feb 10 2017, 9:35 AM
lib/Target/ARM/ARM.h
57

This variable isn't used for anything, and I don't see why you declare it.

rmaprath updated this revision to Diff 88186.Feb 13 2017, 5:40 AM

Address review comments: Get rid of the unnecessary pass id definition in the llvm namespace.

rmaprath marked an inline comment as done.Feb 13 2017, 5:40 AM
rmaprath abandoned this revision.Feb 13 2017, 6:46 AM

Abandoning: @jmolloy has committed a semantically equivalent patch: https://reviews.llvm.org/rL294948