Page MenuHomePhabricator

Change from "XFAIL: libcpp-no-exceptions" to "UNSUPPORTED: libcpp-no-exceptions" tests that only check exceptions and nothing else
ClosedPublic

Authored by rogfer01 on Oct 28 2016, 8:10 AM.

Details

Summary

This is a follow up of D24562.

These tests do not check anything but exceptions, so it makes sense to mark them as UNSUPPORTED under a library built without exceptions.

Diff Detail

Repository
rL LLVM

Event Timeline

rogfer01 updated this revision to Diff 76190.Oct 28 2016, 8:10 AM
rogfer01 retitled this revision from to Change from "XFAIL: libcpp-no-exceptions" to "UNSUPPORTED: libcpp-no-exceptions" tests that only check exceptions and nothing else.
rogfer01 updated this object.
rogfer01 added reviewers: rmaprath, EricWF, mclow.lists.
rogfer01 added a subscriber: cfe-commits.
rmaprath edited edge metadata.Oct 30 2016, 1:57 PM

This looks sensible to me. I'll let @EricWF approve.

/ Asiri

EricWF accepted this revision.Oct 30 2016, 4:04 PM
EricWF edited edge metadata.

LGTM as well.

This revision is now accepted and ready to land.Oct 30 2016, 4:04 PM
This revision was automatically updated to reflect the committed changes.