Index: include/__config =================================================================== --- include/__config +++ include/__config @@ -34,6 +34,7 @@ #endif #if defined(_LIBCPP_ABI_UNSTABLE) || _LIBCPP_ABI_VERSION >= 2 +#define _LIBCPP_ABI_EXTERN_TEMPLATE_SYMBOLS_VERSION 2 // Change short string representation so that string data starts at offset 0, // improving its alignment in some cases. #define _LIBCPP_ABI_ALTERNATE_STRING_LAYOUT @@ -49,6 +50,7 @@ #define _LIBCPP_ABI_FIX_UNORDERED_CONTAINER_SIZE_TYPE #define _LIBCPP_ABI_VARIADIC_LOCK_GUARD #elif _LIBCPP_ABI_VERSION == 1 +#define _LIBCPP_ABI_EXTERN_TEMPLATE_SYMBOLS_VERSION 1 // Feature macros for disabling pre ABI v1 features. All of these options // are deprecated. #if defined(__FreeBSD__) @@ -610,11 +612,19 @@ #endif #ifndef _LIBCPP_INLINE_VISIBILITY -#define _LIBCPP_INLINE_VISIBILITY __attribute__ ((__visibility__("hidden"), __always_inline__)) +# if __has_attribute(__internal_linkage__) +# define _LIBCPP_INLINE_VISIBILITY __attribute__((__internal_linkage__, __always_inline__)) +# else +# define _LIBCPP_INLINE_VISIBILITY __attribute__ ((__visibility__("hidden"), __always_inline__)) +# endif #endif #ifndef _LIBCPP_ALWAYS_INLINE -#define _LIBCPP_ALWAYS_INLINE __attribute__ ((__visibility__("hidden"), __always_inline__)) +# if __has_attribute(__internal_linkage__) +# define _LIBCPP_ALWAYS_INLINE __attribute__((__internal_linkage__, __always_inline__)) +# else +# define _LIBCPP_ALWAYS_INLINE __attribute__ ((__visibility__("hidden"), __always_inline__)) +# endif #endif #ifndef _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY Index: src/string.cpp =================================================================== --- src/string.cpp +++ src/string.cpp @@ -29,6 +29,29 @@ string operator+, allocator >(char const*, string const&); +// These external instantiations are required to maintain dylib compatibility +// for ABI v1 when using __attribute__((internal_linkage)) as opposed to +// __attribute__((visibility("hidden"), always_inline)). +#if _LIBCPP_ABI_EXTERN_TEMPLATE_SYMBOLS_VERSION == 1 +template basic_string::iterator +basic_string::insert(basic_string::const_iterator, + char const *, char const *); + +template basic_string::iterator +basic_string::insert(basic_string::const_iterator, + wchar_t const *, wchar_t const *); + +template basic_string & +basic_string::replace(basic_string::const_iterator, + basic_string::const_iterator, + char const *, char const *); + +template basic_string & +basic_string::replace(basic_string::const_iterator, + basic_string::const_iterator, + wchar_t const *, wchar_t const *); +#endif // _LIBCPP_ABI_EXTERN_TEMPLATE_SYMBOLS_VERSION + namespace {