This is an archive of the discontinued LLVM Phabricator instance.

ELF/AMDGPU: Add support for GOT relocations
ClosedPublic

Authored by tstellarAMD on Jun 17 2016, 2:30 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

tstellarAMD retitled this revision from to ELF/AMDGPU: Add support for GOT relocations.
tstellarAMD updated this object.
tstellarAMD added a subscriber: llvm-commits.
ruiu added inline comments.Jun 24 2016, 4:39 AM
ELF/Target.cpp
1426 ↗(On Diff #61131)

fatal() is called in relocateOne, so unknown relocations are fatal. Can we also call fatal here?

Also, please run clang-format on this patch.

Use fatal() instead of error() and run clang-format.

kzhuravl accepted this revision.Jun 24 2016, 9:55 AM
kzhuravl edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jun 24 2016, 9:55 AM
ruiu accepted this revision.Jun 24 2016, 9:29 PM
ruiu edited edge metadata.

LGTM with a stylistic change.

ELF/Target.cpp
1434 ↗(On Diff #61801)

fatal does not return, so remove this comment. Also, please move default: at end of this switch to make the order of the cases the same as the above switch.

This revision was automatically updated to reflect the committed changes.