Index: clang-tools-extra/trunk/clang-rename/USRLocFinder.cpp =================================================================== --- clang-tools-extra/trunk/clang-rename/USRLocFinder.cpp +++ clang-tools-extra/trunk/clang-rename/USRLocFinder.cpp @@ -124,20 +124,11 @@ } bool VisitCXXStaticCastExpr(clang::CXXStaticCastExpr *Expr) { - clang::QualType Type = Expr->getType(); - // See if this a cast of a pointer. - const RecordDecl* Decl = Type->getPointeeCXXRecordDecl(); - if (!Decl) { - // See if this is a cast of a reference. - Decl = Type->getAsCXXRecordDecl(); - } - - if (Decl && getUSRForDecl(Decl) == USR) { - SourceLocation Location = Expr->getTypeInfoAsWritten()->getTypeLoc().getBeginLoc(); - LocationsFound.push_back(Location); - } + return handleCXXNamedCastExpr(Expr); + } - return true; + bool VisitCXXDynamicCastExpr(clang::CXXDynamicCastExpr *Expr) { + return handleCXXNamedCastExpr(Expr); } // Non-visitors: @@ -159,6 +150,23 @@ } } + bool handleCXXNamedCastExpr(clang::CXXNamedCastExpr *Expr) { + clang::QualType Type = Expr->getType(); + // See if this a cast of a pointer. + const RecordDecl* Decl = Type->getPointeeCXXRecordDecl(); + if (!Decl) { + // See if this is a cast of a reference. + Decl = Type->getAsCXXRecordDecl(); + } + + if (Decl && getUSRForDecl(Decl) == USR) { + SourceLocation Location = Expr->getTypeInfoAsWritten()->getTypeLoc().getBeginLoc(); + LocationsFound.push_back(Location); + } + + return true; + } + // All the locations of the USR were found. const std::string USR; // Old name that is renamed. Index: clang-tools-extra/trunk/test/clang-rename/DynamicCastExpr.cpp =================================================================== --- clang-tools-extra/trunk/test/clang-rename/DynamicCastExpr.cpp +++ clang-tools-extra/trunk/test/clang-rename/DynamicCastExpr.cpp @@ -0,0 +1,25 @@ +// RUN: cat %s > %t.cpp +// RUN: clang-rename -offset=186 -new-name=X %t.cpp -i -- +// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s +class Base { + virtual int getValue() const = 0; +}; + +class Derived : public Base { +public: + int getValue() const { + return 0; + } +}; + +int main() { + Derived D; + const Base &Reference = D; + const Base *Pointer = &D; + + dynamic_cast(Reference).getValue(); // CHECK: dynamic_cast + dynamic_cast(Pointer)->getValue(); // CHECK: dynamic_cast +} + +// Use grep -FUbo 'Derived' to get the correct offset of foo when changing +// this file.