This is an archive of the discontinued LLVM Phabricator instance.

[LibFuzzer] Emit error during configuration if LLVM_USE_SANITIZER is not correctly set.
ClosedPublic

Authored by delcypher on May 25 2016, 10:16 PM.

Details

Summary

[LibFuzzer] Emit error during configuration if LLVM_USE_SANITIZER is not correctly set.

Previously CMake would successfully configure and compile (with warnings
about `-fsanitize-coverage=...` being unused) but the tests LibFuzzer
tests would fail.

This patch is dependent on http://reviews.llvm.org/D20558

Diff Detail

Repository
rL LLVM

Event Timeline

delcypher updated this revision to Diff 58567.May 25 2016, 10:16 PM
delcypher retitled this revision from to [LibFuzzer] Emit error during configuration if LLVM_USE_SANITIZER is not correctly set..
delcypher updated this object.
delcypher added reviewers: kcc, aizatsky.
kcc accepted this revision.May 26 2016, 9:56 AM
kcc edited edge metadata.

I would rephrase it to something like this:
Currently libFuzzer and its tests require LLVM_USE_SANITIZER=Address and LLVM_USE_SANITIZE_COVERAGE=YES to be set.
Ok to commit with such or similar phrasing.

This revision is now accepted and ready to land.May 26 2016, 9:56 AM

@kcc : I can change the phrasing if you like but isn't mentioning LLVM_USE_SANITIZE_COVERAGE=YES redundant because the user will only see this message if they set LLVM_USE_SANITIZE_COVERAGE=YES?

kcc added a comment.May 26 2016, 12:39 PM

@kcc : I can change the phrasing if you like but isn't mentioning LLVM_USE_SANITIZE_COVERAGE=YES redundant because the user will only see this message if they set LLVM_USE_SANITIZE_COVERAGE=YES?

It might be redundant but it's also correct and may help avoid some confusion.

This revision was automatically updated to reflect the committed changes.